Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub query #246

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Pubsub query #246

merged 5 commits into from
Jul 5, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Jun 27, 2024

@wyfo wyfo marked this pull request as ready for review July 5, 2024 09:44
Mallets
Mallets reviewed Jul 5, 2024
View reviewed changes
src/qos.rs Show resolved Hide resolved
Mallets
Mallets reviewed Jul 5, 2024
View reviewed changes
src/query.rs Show resolved Hide resolved
Mallets
Mallets reviewed Jul 5, 2024
View reviewed changes
tests/stubs_check.py Outdated Show resolved Hide resolved
Mallets
Mallets requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just add license headers.

@wyfo
Copy link
Contributor Author

wyfo commented Jul 5, 2024

This PR is based on the previous ones, I've fixed licence headers in #243

@wyfo
Copy link
Contributor Author

wyfo commented Jul 5, 2024

I will need to rebase when #243 will be merged

@wyfo wyfo requested a review from Mallets July 5, 2024 14:00
@Mallets Mallets merged commit 26f9d02 into eclipse-zenoh:dev/1.0.0 Jul 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyfo @Mallets