Add z_bytes example #673
Merged
Add z_bytes example #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
force-pushed
the
ft_zbytes_example
branch
from
992c0b4 to
72b9bf2
Compare
sashacmc
suggested changes
Sep 17, 2024
12 tasks
include/zenoh-pico/api/encoding.h
Outdated
| // Constant alias for string: `"zenoh/bytes"`. | ||
| // | ||
| // Usually used for types: `uint8_t[]`. | ||
| extern const z_owned_encoding_t ENCODING_ZENOH_BYTES; |
There was a problem hiding this comment.
please see how encoding constants are implemented in zenoh-c: https://github.com/eclipse-zenoh/zenoh-c/blob/610a4b9057a703ecba5f098e084bdc40e4e786f3/include/zenoh_commons.h#L2254
jean-roland
force-pushed
the
ft_zbytes_example
branch
from
4b00337 to
f53bc01
Compare
jean-roland
force-pushed
the
ft_zbytes_example
branch
from
de7b72d to
5a46325
Compare
|
We will also need to add the docs for encoding functions, and probably an example of using slice iterator similar to https://github.com/eclipse-zenoh/zenoh/blob/db755e3e75733b10cd9b9fa63acb624fd4e57a39/examples/examples/z_bytes.rs#L107C1-L112C6 |
examples/unix/c11/z_bytes.c
Outdated
| z_view_slice_t curr_slice; | ||
| while (z_bytes_slice_iterator_next(&slice_iter, &curr_slice)) { | ||
| printf("slice len: %d, slice data: '%.*s'\n", (int)z_slice_len(z_view_slice_loan(&curr_slice)), | ||
| (int)z_slice_len(z_view_slice_loan(&curr_slice)), |
There was a problem hiding this comment.
this is not good since it will print garbage, could we rather print slice content as list of hexadecimal values ?
jean-roland
force-pushed
the
ft_zbytes_example
branch
5 times, most recently
from
3d3b42e to
6f3a235
Compare
jean-roland
force-pushed
the
ft_zbytes_example
branch
from
6f3a235 to
bfecb48
Compare
sashacmc
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662.
Adds missing encoding constants.