z_bytes example #218
Merged
z_bytes example #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellowhatter
added
enhancement
12 tasks
Mallets
reviewed
Sep 19, 2024
| const auto output = payload.deserialize<uint32_t>(); | ||
| assert(input == output); | ||
| // Corresponding encoding to be used in operations like `.put()`, `.reply()`, etc. | ||
| const auto encoding = Encoding("zenoh/uint32"); |
There was a problem hiding this comment.
Do we have Encoding constants instead of using the string form?
There was a problem hiding this comment.
not yet, will do in separate pr, since they are introduced in pico by eclipse-zenoh/zenoh-pico#673
|
Protobuf example is still missing |
Added! |
|
[closes #216] |
Mallets
reviewed
Sep 20, 2024
examples/universal/z_bytes.cxx
Outdated
| GOOGLE_PROTOBUF_VERIFY_VERSION; | ||
|
|
||
| // Construct PB message | ||
| Book input; |
There was a problem hiding this comment.
Mallets
reviewed
Sep 20, 2024
Mallets
approved these changes
Sep 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.