FreeRTOS-Plus-TCP port #239

bjsowa · 2023-08-11T17:05:55Z

Features to implement:

cguimaraes · 2023-08-12T12:54:40Z

@bjsowa check failing test regarding the Eclipse ECA. Otherwise, we will not be able to merge this PR.

Do you have a timeline for the remaining features?

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa · 2023-08-12T14:02:16Z

@bjsowa check failing test regarding the Eclipse ECA. Otherwise, we will not be able to merge this PR.

Fixed

Do you have a timeline for the remaining features?

I don't.

cguimaraes

A first quick review.
Tests must be also provided...at least build tests.

src/system/freertos_plus_tcp/system.c

cguimaraes · 2023-08-12T18:26:44Z

src/system/freertos_plus_tcp/network.c

+        ret = _Z_ERR_GENERIC;
+    }
+
+    ep->_iptcp->ai_addr->sin_family = FREERTOS_AF_INET4;


isn't this value set by getaddrinfo?

Unfortunately not, getaddrinfo only sets ai_family but does not write it to ai_addr->sin_family. I changed it so it at least uses the value returned by getaddrinfo.

src/system/freertos_plus_tcp/system.c

cguimaraes · 2023-08-13T16:24:16Z

src/system/freertos_plus_tcp/system.c

+
+unsigned long z_clock_elapsed_ms(z_clock_t *instant) { return z_time_elapsed_ms(instant); }
+
+unsigned long z_clock_elapsed_s(z_clock_t *instant) { return z_time_elapsed_ms(instant) * 1000; }


This will return seconds but useconds instead.

Fixed it. It is worth noting that the emscripten port, which I used for reference, has the same issue.

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa · 2023-08-28T14:22:23Z

@cguimaraes I added TCP support, some examples and CI workflow. Could you review the changes?

The examples use POSIX port of FreeRTOS and network interface implementation that uses SLiRP library to emulate a userspace NAT network. I was able to use the examples on Linux in client mode with a Zenoh Router running on the host. Peer mode won't work as this port does not support incoming connections.

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa · 2023-08-29T14:38:38Z

@cguimaraes I added Multi threading support and extended Zenoh-pico API to allow passing port-specific task attributes when creating read and lease tasks (example usage in z_pub.c). Let me know what you think about it.

Multicast is not fully supported in FreeRTOS-Plus-TCP (see FreeRTOS/FreeRTOS-Plus-TCP#962) so I'll have to pass on UDP Multicast for now. I'll also pass on IPv6 support as I don't need it.

I'll mark this PR as Ready for review once I'll have it tested on a microcontroller.

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa · 2023-09-21T20:13:41Z

I updated the PR. @p-avital Could you rerun the workflows?

Signed-off-by: Błażej Sowa <[email protected]>

Mallets · 2023-10-26T14:12:41Z

@bjsowa I've just realised that this PR is still open. In the meanwhile we have released zenoh 0.10.0 and it seems there are some conflicts to be resolved before merging.

bjsowa · 2023-10-26T23:43:47Z

@bjsowa I've just realised that this PR is still open. In the meanwhile we have released zenoh 0.10.0 and it seems there are some conflicts to be resolved before merging.

@Mallets I resolved the conflicts.

cguimaraes

My previous comments are addressed

bjsowa mentioned this pull request Aug 11, 2023

FreeRTOS port #129

Closed

FreeRTOS-Plus-TCP port: system and UDP unicast

3d954cd

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa force-pushed the freertos branch from 95ff561 to 3d954cd Compare August 12, 2023 13:57

cguimaraes requested changes Aug 12, 2023

View reviewed changes

cguimaraes requested changes Aug 13, 2023

View reviewed changes

bjsowa added 6 commits August 14, 2023 00:50

Fix clock_elapsed_s method

2d9ed40

Avoid double free

d3e8cc1

Add TCP transport

f949eb3

Fix build when only TCP is enabled

8e2d99d

Initial FreeRTOS-Plus-TCP example

ba1c4c0

Signed-off-by: Błażej Sowa <[email protected]>

Initial CI workflow

d502492

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa force-pushed the freertos branch from a488e28 to d502492 Compare August 25, 2023 16:28

bjsowa added 15 commits August 28, 2023 12:06

Fix newline character in printf

c8c8b3d

Signed-off-by: Błażej Sowa <[email protected]>

Fix network driver checksum options

b86ce98

Signed-off-by: Błażej Sowa <[email protected]>

Fix printf newline

46bde55

Signed-off-by: Błażej Sowa <[email protected]>

Make vAppTask static

6314ac9

Signed-off-by: Błażej Sowa <[email protected]>

Resolve MAC address of gateway before running Zenoh app

649fed5

Signed-off-by: Błażej Sowa <[email protected]>

Set zenoh debug level

c7cb1ef

Signed-off-by: Błażej Sowa <[email protected]>

Increase socket timeout

9965500

Signed-off-by: Błażej Sowa <[email protected]>

Fix segfault when failed to create endpoint

98be97f

Signed-off-by: Błażej Sowa <[email protected]>

Fix warning about overflow in int conversion when using 64-bit system

28fe14f

Signed-off-by: Błażej Sowa <[email protected]>

Use ai_family returned by getaddrinfo

1390425

Signed-off-by: Błażej Sowa <[email protected]>

Fix tcp and udp read methods

933324f

Signed-off-by: Błażej Sowa <[email protected]>

Retain original contributor in z_pub example

8633333

Signed-off-by: Błażej Sowa <[email protected]>

Add z_scout example

1c0d0b3

Signed-off-by: Błażej Sowa <[email protected]>

Base the z_pub example on unix example

663724b

Signed-off-by: Błażej Sowa <[email protected]>

Add more examples

fe5d30e

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa added 9 commits August 29, 2023 12:29

Multi-threading initial

7fc8da0

Signed-off-by: Błażej Sowa <[email protected]>

Mark UDP Multicast as unsupported

841924c

Signed-off-by: Błażej Sowa <[email protected]>

Fix _z_task_free

8148874

Signed-off-by: Błażej Sowa <[email protected]>

Use multi-threading in examples

070b5a6

Signed-off-by: Błażej Sowa <[email protected]>

Add sleep to z_sub example

daa800d

Signed-off-by: Błażej Sowa <[email protected]>

Allow passing task attributes to read and lease tasks

424421d

Signed-off-by: Błażej Sowa <[email protected]>

Use static tasks in z_pub example

62556f9

Signed-off-by: Błażej Sowa <[email protected]>

Remove redundant print

a364a6e

Signed-off-by: Błażej Sowa <[email protected]>

Add more examples

683a4d8

Signed-off-by: Błażej Sowa <[email protected]>

Change char* to const char*

5d92775

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa force-pushed the freertos branch from 15e55bf to 5d92775 Compare August 30, 2023 12:44

Update license headers

63c089b

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa force-pushed the freertos branch from 4582b64 to 63c089b Compare August 30, 2023 13:52

Update README

2291ddd

Signed-off-by: Błażej Sowa <[email protected]>

bjsowa force-pushed the freertos branch from a36dc85 to 2291ddd Compare August 30, 2023 14:22

bjsowa marked this pull request as ready for review August 30, 2023 14:23

bjsowa requested a review from cguimaraes August 30, 2023 14:24

bjsowa added 3 commits September 21, 2023 21:39

Merge branch 'master' into freertos

a547d02

Fix config keys

4e81de9

Fix fprintzid

d6d757f

Ignore freertos_plus_tcp port sources when using PlatformIO

376ed99

Signed-off-by: Błażej Sowa <[email protected]>

Merge remote-tracking branch 'zenoh/master' into freertos

7f9c2cf

cguimaraes approved these changes Oct 27, 2023

View reviewed changes

Mallets approved these changes Oct 27, 2023

View reviewed changes

Mallets merged commit 2ee5282 into eclipse-zenoh:master Oct 30, 2023
27 checks passed

bjsowa deleted the freertos branch October 30, 2023 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FreeRTOS-Plus-TCP port #239

FreeRTOS-Plus-TCP port #239

bjsowa commented Aug 11, 2023 •

edited

Loading

cguimaraes commented Aug 12, 2023

bjsowa commented Aug 12, 2023

cguimaraes left a comment

cguimaraes Aug 12, 2023

bjsowa Aug 28, 2023

cguimaraes Aug 13, 2023

bjsowa Aug 13, 2023

bjsowa commented Aug 28, 2023

bjsowa commented Aug 29, 2023

bjsowa commented Sep 21, 2023

Mallets commented Oct 26, 2023

bjsowa commented Oct 26, 2023

cguimaraes left a comment


		unsigned long z_clock_elapsed_ms(z_clock_t *instant) { return z_time_elapsed_ms(instant); }

		unsigned long z_clock_elapsed_s(z_clock_t instant) { return z_time_elapsed_ms(instant) 1000; }

FreeRTOS-Plus-TCP port #239

FreeRTOS-Plus-TCP port #239

Conversation

bjsowa commented Aug 11, 2023 • edited Loading

cguimaraes commented Aug 12, 2023

bjsowa commented Aug 12, 2023

cguimaraes left a comment

Choose a reason for hiding this comment

cguimaraes Aug 12, 2023

Choose a reason for hiding this comment

bjsowa Aug 28, 2023

Choose a reason for hiding this comment

cguimaraes Aug 13, 2023

Choose a reason for hiding this comment

bjsowa Aug 13, 2023

Choose a reason for hiding this comment

bjsowa commented Aug 28, 2023

bjsowa commented Aug 29, 2023

bjsowa commented Sep 21, 2023

Mallets commented Oct 26, 2023

bjsowa commented Oct 26, 2023

cguimaraes left a comment

Choose a reason for hiding this comment

bjsowa commented Aug 11, 2023 •

edited

Loading