Pr 2978 #2989
Pr 2978 #2989
Conversation
Virtual configuration IU in p2.inf does not work in 4.0.3 (works in 3.0.5)
laeubi
added
the
backport-to-tycho-4.0.x
Currently units from p2.inf are not published to the target-platform what can fail resolving when these are referenced in the project. This publishes these units into the target-platform state of the project. Fix eclipse-tycho#2977
|
Jenkins testfailure is an instability from |
|
@laeubi that was a really fast resolution!!! Thank you very much. Is there any plan to release a 4.0.4 soon? Just asking to plan ahead on my side. |
| } | ||
| AdviceFileAdvice advice; | ||
| if (PackagingType.TYPE_ECLIPSE_PLUGIN.equals(reactorProject.getPackaging())) { | ||
| advice = new AdviceFileAdvice(reactorProject.getArtifactId(), Version.parseVersion("1.0.0"), |
There was a problem hiding this comment.
Is this hardcoded version 1.0.0 irrelevant? what if the declared unit sets its version to anything else?
(same below on the else branch of the if)
There was a problem hiding this comment.
The version is only used to check if the advice should be applied to a unit, as we are not interested in the advice itself but only the additional units it defines the version has actually no influence here.
|
The plan was to release it last week :-D But I considered this important enough to delay it by some days, if nothing crucial came up I'll probably make a release at the weekend or on Monday. |
These changes show that the fix for issue eclipse-tycho#2977 made in PR eclipse-tycho#2989 was partial. When there is another bundle/plugin that requires the bundle which contains the p2.inf file that provides and requires the virtual IU the original error is triggered again even with Tycho 4.0.4.
This includes the test and a fix for