Skip to content

Commit

Permalink
Add reproducer to show partial fix of eclipse-tycho#2977
Browse files Browse the repository at this point in the history
These changes show that the fix for issue eclipse-tycho#2977 made in PR eclipse-tycho#2989 was
partial.

When there is another bundle/plugin that requires the bundle which
contains the p2.inf file that provides and requires the virtual IU the
original error is triggered again even with Tycho 4.0.4.
  • Loading branch information
mdaloia committed Nov 10, 2023
1 parent 8c85a01 commit e73ce2a
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 13 deletions.
13 changes: 0 additions & 13 deletions tycho-its/projects/p2Inf.virtualUnit/bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,4 @@
<artifactId>pvu.bundle</artifactId>
<packaging>eclipse-plugin</packaging>

<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho-version}</version>
<configuration>
<pomDependencies>consider</pomDependencies>
</configuration>
</plugin>
</plugins>
</build>

</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: pvu.bundle2
Bundle-SymbolicName: pvu.bundle2;singleton:=true
Bundle-Version: 1.0.0.qualifier
Bundle-Vendor: TEST
Bundle-RequiredExecutionEnvironment: JavaSE-17
Require-Bundle: pvu.bundle
2 changes: 2 additions & 0 deletions tycho-its/projects/p2Inf.virtualUnit/bundle2/build.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bin.includes = META-INF/,\
.
16 changes: 16 additions & 0 deletions tycho-its/projects/p2Inf.virtualUnit/bundle2/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<project
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>tycho-its-project.p2Inf.virtualUnit</groupId>
<artifactId>parent</artifactId>
<version>1.0.0-SNAPSHOT</version>
</parent>

<artifactId>pvu.bundle2</artifactId>
<packaging>eclipse-plugin</packaging>

</project>
9 changes: 9 additions & 0 deletions tycho-its/projects/p2Inf.virtualUnit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<modules>
<module>bundle</module>
<module>bundle2</module>
</modules>

<build>
Expand All @@ -25,6 +26,14 @@
<version>${tycho-version}</version>
<extensions>true</extensions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>target-platform-configuration</artifactId>
<version>${tycho-version}</version>
<configuration>
<pomDependencies>consider</pomDependencies>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit e73ce2a

Please sign in to comment.