Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3464] Improve i18n support for domain and view forms #3465

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AresEkb
Copy link
Contributor

@AresEkb AresEkb commented May 13, 2024

Bug: #3464

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch 11 times, most recently from ca6beb1 to cc3e191 Compare May 14, 2024 08:17
@AresEkb AresEkb marked this pull request as ready for review May 14, 2024 08:51
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch 2 times, most recently from d322b77 to 9bf79f2 Compare May 15, 2024 05:09
@AresEkb AresEkb requested a review from AxelRICHARD as a code owner May 15, 2024 05:09
@AresEkb AresEkb marked this pull request as draft May 15, 2024 06:30
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch from 9bf79f2 to ef5c4ae Compare May 15, 2024 09:03
@AresEkb AresEkb marked this pull request as ready for review May 15, 2024 10:10
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch 3 times, most recently from b067a1e to a27d7b8 Compare May 16, 2024 16:50
@AresEkb AresEkb requested a review from gcoutable as a code owner May 16, 2024 16:50
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch from a27d7b8 to c0b2de7 Compare May 16, 2024 18:29
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch 4 times, most recently from c214f26 to 882846e Compare June 17, 2024 08:13
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch 2 times, most recently from 70ae935 to 6c859b9 Compare July 1, 2024 14:53
@AresEkb AresEkb force-pushed the den/enh/description-forms-i18n-enhancement branch from 6c859b9 to b9f91c6 Compare July 3, 2024 12:59
@AresEkb AresEkb marked this pull request as draft August 28, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant