Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n support for domain and view forms #3464

Open
1 task done
AresEkb opened this issue May 13, 2024 · 0 comments
Open
1 task done

Improve i18n support for domain and view forms #3464

AresEkb opened this issue May 13, 2024 · 0 comments

Comments

@AresEkb
Copy link
Contributor

AresEkb commented May 13, 2024

  • I have checked that this feature has not yet been suggested by someone else.

The pull request: #3465

Expected behavior

We need to localize domain and view forms. But there are two problems:

  1. Some strings are hard-coded on backend
  2. Identifiers of child creation descriptions are locale-dependent. When I add localization files tests become broken

I suggest to fix it and simplify localization

Cuttings backs

No.

Potential side effects

No.

Describe alternatives you've considered

Add a localization on the application level, but it's a way more complicated and impossible for some strings, because they are hard-coded.

What's changed

  1. Added EEnumLiteralLabelProvider that gets a localized label for EEnumLiteral

  2. Added i18n support for DomainPropertiesConfigurer, MultipleDomainPropertiesConfigurer, FixedColorPropertiesConfigurer, PropertiesWidgetCreationService, NodeStylePropertiesConfigurer, EdgeStylePropertiesConfigurer and some other classes

  3. Changed DefaultEditService::getChildCreationDescriptions() and DefaultEditService::createChild(). They used helper.getCreateChildText() to get a localized child description identifiers. So these identifiers changed after I added localization and tests was broken. Now I replaced identifiers by ones of the form: containmentFeatureName-ChildClassName. They guaranteed to be locale-independent and unique

  4. Added to DefaultLabelService::getLabel() usage of IItemLabelProvider

  5. Removed packages/view/backend/sirius-components-view-emf/src/main/resources/messages/sirius-web-emf.properties. It overrided packages/emf/backend/sirius-components-emf/src/main/resources/messages/sirius-web-emf.properties during tests in GitHub and leaded to strange test fails

  6. Added ru localization for several packages

AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 13, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 15, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 15, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 15, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 16, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 16, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 16, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue May 16, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jun 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jun 14, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jun 17, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jun 17, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jul 1, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jul 1, 2024
AresEkb added a commit to AresEkb/sirius-web that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant