-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve i18n support for domain and view forms #3464
Comments
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
39 tasks
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 13, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 15, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 15, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 15, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 16, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 16, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 16, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
May 16, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jun 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jun 14, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jun 17, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jun 17, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jul 1, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jul 1, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
AresEkb
added a commit
to AresEkb/sirius-web
that referenced
this issue
Jul 3, 2024
Bug: eclipse-sirius#3464 Signed-off-by: Denis Nikiforov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The pull request: #3465
Expected behavior
We need to localize domain and view forms. But there are two problems:
I suggest to fix it and simplify localization
Cuttings backs
No.
Potential side effects
No.
Describe alternatives you've considered
Add a localization on the application level, but it's a way more complicated and impossible for some strings, because they are hard-coded.
What's changed
Added
EEnumLiteralLabelProvider
that gets a localized label for EEnumLiteralAdded i18n support for
DomainPropertiesConfigurer
,MultipleDomainPropertiesConfigurer
,FixedColorPropertiesConfigurer
,PropertiesWidgetCreationService
,NodeStylePropertiesConfigurer
,EdgeStylePropertiesConfigurer
and some other classesChanged
DefaultEditService::getChildCreationDescriptions()
andDefaultEditService::createChild()
. They usedhelper.getCreateChildText()
to get a localized child description identifiers. So these identifiers changed after I added localization and tests was broken. Now I replaced identifiers by ones of the form:containmentFeatureName-ChildClassName
. They guaranteed to be locale-independent and uniqueAdded to
DefaultLabelService::getLabel()
usage ofIItemLabelProvider
Removed
packages/view/backend/sirius-components-view-emf/src/main/resources/messages/sirius-web-emf.properties
. It overridedpackages/emf/backend/sirius-components-emf/src/main/resources/messages/sirius-web-emf.properties
during tests in GitHub and leaded to strange test failsAdded ru localization for several packages
The text was updated successfully, but these errors were encountered: