Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for javax support by the E4 injector #1510

Merged

Conversation

HannesWell
Copy link
Member

Part of #1056

I also added a corresponding N&N entry: eclipse-platform/www.eclipse.org-eclipse#79

@HannesWell HannesWell force-pushed the javax-support-deprecation-notice branch from 3c7fb24 to dac48cc Compare November 5, 2023 09:12
@HannesWell
Copy link
Member Author

Btw. does anybody know why tonight the I-builds did not run?

@merks
Copy link
Contributor

merks commented Nov 5, 2023

Maybe the switch back to standard time overnight has changed when you should expect that build to happen by 1 hour...

@merks
Copy link
Contributor

merks commented Nov 5, 2023

BTW, I'd like the/a build to happen after I merge this so that I can use it in PDE:

eclipse-equinox/p2#377

@iloveeclipse
Copy link
Member

Btw. does anybody know why tonight the I-builds did not run?

It looks lile the builds were changed by @MohananRahul, but I fail to understand the logic behind the config:
https://ci.eclipse.org/releng/job/Builds/job/I-build-4.30/jobConfigHistory/showDiffFiles?timestamp1=2023-11-04_12-06-41&timestamp2=2023-11-04_12-11-42

@iloveeclipse
Copy link
Member

Looking closer into the config, it says : "would next run at Sunday, November 5, 2023 at 6:00:59 AM Eastern Standard Time."

image

@MohananRahul
Copy link
Contributor

Btw. does anybody know why tonight the I-builds did not run?

It looks lile the builds were changed by @MohananRahul, but I fail to understand the logic behind the config: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.30/jobConfigHistory/showDiffFiles?timestamp1=2023-11-04_12-06-41&timestamp2=2023-11-04_12-11-42

Milestone week will have 2 builds.

@HannesWell
Copy link
Member Author

Back to the actual topic: How should we proceed with the deprecation and eventual removal of javax-support?

But we can of course think about extending the deprecation period. As a suggestion I changed to text to:
scheduled to be disabled by default after the December 2026 release and scheduled for removal after the December 2028 release., which means three years until being disabled by default and five years until support is fully removed.
If a Plugin does not manage to apply the simple change and produce new builds I would consider it dead anyways.

What do you think about that? If there is real demand the javax-support could also stay (disabled by default?) until it causes real pain.

@akurtakov
Copy link
Member

akurtakov commented Nov 10, 2023

Back to the actual topic: How should we proceed with the deprecation and eventual removal of javax-support?

But we can of course think about extending the deprecation period. As a suggestion I changed to text to:
scheduled to be disabled by default after the December 2026 release and scheduled for removal after the December 2028 release., which means three years until being disabled by default and five years until support is fully removed.
If a Plugin does not manage to apply the simple change and produce new builds I would consider it dead anyways.

What do you think about that? If there is real demand the javax-support could also stay (disabled by default?) until it causes real pain.

I think it's already what we have . The document says that something is deprecated and will stay until XXX date at least . E.g. if you look at ICU4J removal item - it's marked as "API removals after June 2022" but it's still there. Similar thing happened with Navigator view.
Setting longer deprecation period will impose self-limit on our self for no good reason in case an issue arise, current workflow doesn't mandate that we remove in January 2025 but that we can remove after January 2025 when we see fit.

@HannesWell
Copy link
Member Author

current workflow doesn't mandate that we remove in January 2025 but that we can remove after January 2025 when we see fit.

That makes sense too.
If there is agreement on this, I can Update the notice to state that compabitlity is retainted/guaranteed for the next two years and from this point on might be removed at any time without further notice.

Btw. I created an update for the N&N entry:
eclipse-platform/www.eclipse.org-eclipse#85

Can we references that in the deprecation notice?

@HannesWell HannesWell force-pushed the javax-support-deprecation-notice branch from dac48cc to 2d158b0 Compare November 18, 2023 09:45
@HannesWell
Copy link
Member Author

Setting longer deprecation period will impose self-limit on our self for no good reason in case an issue arise, current workflow doesn't mandate that we remove in January 2025 but that we can remove after January 2025 when we see fit.

I updated the deprecation notice to reflect that.
@akurtakov, @laeubi please have a look. If you are fine with this I would like to submit that soon so that it will be in the doc of the upcomming release.

@HannesWell HannesWell force-pushed the javax-support-deprecation-notice branch from 2d158b0 to 31ec6d8 Compare November 18, 2023 10:06
@HannesWell
Copy link
Member Author

Slightly enhanced the section about how to explicitly enable and disable javax-annotation processing.

@HannesWell
Copy link
Member Author

Setting longer deprecation period will impose self-limit on our self for no good reason in case an issue arise, current workflow doesn't mandate that we remove in January 2025 but that we can remove after January 2025 when we see fit.

I updated the deprecation notice to reflect that.

Since the updated message is (I assume) in the sense of @akurtakov I'm going to merge this now.

@HannesWell HannesWell merged commit 2504e05 into eclipse-platform:master Nov 18, 2023
1 of 2 checks passed
@HannesWell HannesWell deleted the javax-support-deprecation-notice branch November 18, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants