Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up the fallout of whatever platform will do with javax.annotation #2103

Open
cdietrich opened this issue Sep 29, 2022 · 4 comments
Open
Labels
Milestone

Comments

@cdietrich
Copy link
Contributor

Follow up the fallout of whatever platform will do with javax.annotation
eclipse-platform/eclipse.platform.releng.aggregator#600

@cdietrich cdietrich added this to the Release_2.29 milestone Sep 29, 2022
@cdietrich
Copy link
Contributor Author

cdietrich commented Sep 29, 2022

we use javax.generated as dependency in xbase. dont know why.
maybe was not removed with java 11 move,

xtext.xtext.generator and jvm model completer seem to search for its availability
xtext.generator needs to be checked

some xbase tests use javax.annotation.Nullable
some xtend tests stuff uses javax.annoation.Resource, ut that ones does not seem to come from jdk. but the eclipse tests might pick it from javax.annotation jar. maybe we can use java.lang.Deprecated or the like instead (or is there a better candiate, am not sure how to deal with ImportsCollectorTest)

@cdietrich
Copy link
Contributor Author

cc @szarnekow

@cdietrich
Copy link
Contributor Author

cdietrich commented Sep 29, 2022

should we deprecate org.eclipse.xtext.xtext.generator.model.annotations.GeneratedClassAnnotation (its opt-in anyway if i see correct)

cdietrich added a commit to eclipse/xtext-extras that referenced this issue Sep 29, 2022
[eclipse-xtext/xtext#2103] remove javax.annotation dep. from manifest too
@cdietrich cdietrich modified the milestones: Release_2.29, Release_2.30 Nov 16, 2022
@cdietrich cdietrich modified the milestones: Release_2.30, Release_2.31 Feb 17, 2023
@cdietrich cdietrich modified the milestones: Release_2.31, Release_2.32 May 22, 2023
@cdietrich cdietrich modified the milestones: Release_2.32, Release_2.33 Aug 27, 2023
@HannesWell
Copy link
Contributor

HannesWell commented Nov 14, 2023

FYI the E4 injector now supports both Jakarta and javax annotations, you can use either one (probably can even mix them or apply both):
https://eclipse.dev/eclipse/news/4.30/platform.php#support-jakarta-annotations

And it will support Javax for at least two more years:
eclipse-platform/eclipse.platform.releng.aggregator#1510

A summary is in eclipse-platform/eclipse.platform.releng.aggregator#1056

@cdietrich cdietrich modified the milestones: Release_2.33, Release_2.34 Nov 17, 2023
@cdietrich cdietrich modified the milestones: Release_2.34, Release_2.35 Feb 27, 2024
@cdietrich cdietrich modified the milestones: Release_2.35, Release_2.36 May 23, 2024
@cdietrich cdietrich modified the milestones: Release_2.36, Release_2.37 Aug 25, 2024
@cdietrich cdietrich modified the milestones: Release_2.37, Release_2.38 Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants