Fix string literal conversion warnings in env

[dylanjtuttle]

Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to (char *)) in env.

This PR contributes to (but does not close) eclipse-openj9/openj9#14859

This PR depends on:

• Step 1:
  • Add 'const' qualifier to some string parameters eclipse-openj9/openj9#18083
  • Fix string literal conversion warnings in compile and oti eclipse-openj9/openj9#18455

and must be merged in coordination with eclipse-openj9/openj9#18467

[hzongaro]

Looks good! Please squash the two commits.

[hzongaro]

Jenkins build all

[dylanjtuttle]

Build failures due to a link error:

16:06:07  /usr/bin/ld: fvtest/compilertest/libtestcompiler.a(OMRCodeGenPhase.cpp.o): in function `OMR::CodeGenPhase::performProcessRelocationsPhase(TR::CodeGenerator*, TR::CodeGenPhase*)':
16:06:07  OMRCodeGenPhase.cpp:(.text+0x88c): undefined reference to `setDllSlip(char*, char*, char*, TR::Compilation*)'
16:06:07  /usr/bin/ld: OMRCodeGenPhase.cpp:(.text+0x8dd): undefined reference to `setDllSlip(char*, char*, char*, TR::Compilation*)'

I'm not sure why it would be a link error instead of a regular compiler error, but maybe it's because I updated the parameter types of setDllSlip in FEBase.cpp, but then not anywhere else for some reason. I can fix that!

[hzongaro]

Build failures due to a link error:

Sorry I missed that! I guess you'll need to update any downstream implementation in OpenJ9 pull request eclipse-openj9/openj9#18467 as well.

[hzongaro]

Looks good. Thanks!

[hzongaro]

Jenkins build all

[hzongaro]

There's an odd failure in eclipse.omr (x86-64 Linux):

42: 
41/50 Test #42: threadRealtimeTest ..................***Exception: SegFault  0.12 sec

I don't think it's related to this pull request, and I found at least one previous reference in pull request 6907 to that failure occurring. Re-running.

[hzongaro]

The x86-64 macOS failures appear to be due to issue #6516:

34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1209: Failure
34:       Expected: rc
34:       Which is: 1
34: To be equal to: 2
34: [  FAILED  ] PortSockTest.poll_functionality_basic (1002 ms)
34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:51: Failure
34:       Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
34:       Which is: -506
34: To be equal to: 0
34: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1259: Failure
34:       Expected: privateOmrPortLibrary->sock_accept(privateOmrPortLibrary, serverSocket, &connectedServerSockAddr, &connectedServerSocket)
34:       Which is: -20
34: To be equal to: 0
34: [  FAILED  ] PortSockTest.poll_functionality_many_sockets (1 ms)
34: [----------] 19 tests from PortSockTest (1008 ms total)
34: 
34: [==========] 246 tests from 21 test cases ran. (203845 ms total)
34: [  PASSED  ] 244 tests.
34: [  FAILED  ] 2 tests, listed below:
34: [  FAILED  ] PortSockTest.poll_functionality_basic
34: [  FAILED  ] PortSockTest.poll_functionality_many_sockets

[hzongaro]

Performing a coordinated merge with eclipse-openj9/openj9#18467