Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string literal conversion warnings in compile, runtime, control, ras, infra #7187

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

dylanjtuttle
Copy link
Contributor

@dylanjtuttle dylanjtuttle commented Nov 16, 2023

Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to (char *)) in compile, runtime, control, ras, and infra.

This PR contributes to (but does not close) eclipse-openj9/openj9#14859

This PR depends on:

and must be merged in coordination with eclipse-openj9/openj9#18470

@dylanjtuttle dylanjtuttle marked this pull request as draft November 16, 2023 20:21
@dylanjtuttle dylanjtuttle changed the title Fix -Wwritable-strings in compile, runtime, control, ras Fix string literal conversion warnings in compile, runtime, control, ras, infra Nov 22, 2023
@dylanjtuttle dylanjtuttle force-pushed the constCharStep3 branch 3 times, most recently from b90378c to dbde370 Compare November 28, 2023 18:57
@dylanjtuttle dylanjtuttle marked this pull request as ready for review December 8, 2023 15:52
compiler/runtime/Runtime.hpp Outdated Show resolved Hide resolved
compiler/compile/OMRSymbolReferenceTable.cpp Outdated Show resolved Hide resolved
compiler/ras/LimitFile.cpp Outdated Show resolved Hide resolved
compiler/compile/OMRSymbolReferenceTable.hpp Show resolved Hide resolved
compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
compiler/control/OMROptions.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I think the changes look good. May I ask you to squash the changes from commit 5b7ddf9 into your other commits?

Fix string literal conversion warnings in compiler/compile

Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in compiler/runtime

Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in compiler/control

Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in compiler/ras

Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in compiler/infra
and related functions

Signed-off-by: Dylan Tuttle <[email protected]>
@hzongaro
Copy link
Contributor

Jenkins build all

@hzongaro hzongaro self-assigned this Dec 11, 2023
@hzongaro
Copy link
Contributor

It looks like a riscv test timed out. Rerunning. . . .

Jenkins build riscv

@hzongaro
Copy link
Contributor

x86-64 macOS test failures are due to known issues #7181 and #6516.

@hzongaro hzongaro merged commit f2ac55a into eclipse-omr:master Dec 13, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants