Update System.arraycopy to support null restricted value type arrays #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
requested review from
hzongaro
and removed request for
mstoodle,
0xdaryl and
vijaysun-omr
1 task
a7ehuo
changed the title
|
@hzongaro May I ask you to review this change? Thank you! |
a7ehuo
force-pushed
the
system-arraycopy-primitive-value-types-PR
branch
from
0bdfa3f to
8bb98cf
Compare
hzongaro
reviewed
Aug 11, 2023
a7ehuo
force-pushed
the
system-arraycopy-primitive-value-types-PR
branch
from
8bb98cf to
d0bf0ce
Compare
|
eclipse.omr x86-64 macOS test failed. It looks to be an known issue #6516 |
hzongaro
reviewed
Aug 21, 2023
Required by JEP 401: If null restricted value type is enabled, we need to preform null check on the value being stored in order to throw a `NullPointerException` if the array is null-restricted and the value to write is null. If it is this case, `System.arraycopy` cannot be transformed into arraycopy instructions. Based on whether or not the source array and the destination array are null restricted value type, and whether or not they are flattened, VP decides whether or not transform `System.arraycopy`. Fixes: eclipse-openj9/openj9#17196,eclipse-openj9/openj9#17586 Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
system-arraycopy-primitive-value-types-PR
branch
from
d0bf0ce to
71ddb70
Compare
|
@hzongaro All comments are addressed. Ready for another review. Thanks! |
|
Jenkins build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by JEP 401: If null restricted value type is enabled, we need to preform null check on the value being stored in order to throw a
NullPointerExceptionif the array is null-restricted and the value to write is null. If it is this case,System.arraycopycannot be transformed into arraycopy instructions.Based on whether or not the source array and the destination array are null restricted value type, and whether or not they are flattened, VP decides whether or not transform
System.arraycopy.Fixes: eclipse-openj9/openj9#17196, eclipse-openj9/openj9#17586