Add tests for Value Type System.arraycopy transformation #17903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ehuo
added
depends:omr
a7ehuo
force-pushed
the
add-test-systemarraycopy-PR
branch
2 times, most recently
from
b676dde to
61fb8f8
Compare
a7ehuo
force-pushed
the
add-test-systemarraycopy-PR
branch
from
61fb8f8 to
0e1ef0e
Compare
a7ehuo
changed the title
a7ehuo
force-pushed
the
add-test-systemarraycopy-PR
branch
from
0e1ef0e to
80c44f7
Compare
hzongaro
reviewed
Sep 15, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
|
@hzongaro All comments are addressed. Ready for another review. Thanks! |
a7ehuo
force-pushed
the
add-test-systemarraycopy-PR
branch
from
80c44f7 to
02d9874
Compare
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
test/functional/Valhalla/src/org/openj9/test/lworld/ValueTypeSystemArraycopyTests.java
Outdated
Show resolved
Hide resolved
hzongaro
reviewed
Sep 19, 2023
Signed-off-by: Annabelle Huo <[email protected]>
a7ehuo
force-pushed
the
add-test-systemarraycopy-PR
branch
from
02d9874 to
5861d55
Compare
|
The latest comments are addressed in 5861d55. Ready for another review. Thanks! |
|
Jenkins test sanity xlinuxval jdknext |
|
Tests including the new tests passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Value Type
System.arraycopytransformation