-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple equinox launcher+exe build launch config and enhance native build doc #640
Add simple equinox launcher+exe build launch config and enhance native build doc #640
Conversation
5cd34e2
to
33d0ef9
Compare
33d0ef9
to
2d54617
Compare
2d54617
to
6274bd7
Compare
- Linux: | ||
- GTK development files. The Package `libgtk-3-dev` is sufficient. | ||
- MacOS: | ||
- XCode Command Line Tools (already present in XCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume to build the Equinox binaries on Mac the requirements are the same as for SWT, as we have discussed in eclipse-platform/eclipse.platform.swt#1174 (comment).
@Phillipus or @HeikoKlare is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HannesWell Yes, I think so. I've built the binaries on my Mac with just the Command Line Tools installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
6274bd7
to
2b6d33f
Compare
81266db
to
1085855
Compare
CONTRIBUTING.md
Outdated
|
||
Be sure to search for existing bugs before you create another one. Remember that | ||
contributions are always welcome! | ||
|
||
### Setting up the Development Environment automatically, using the Eclipse Installer (Oomph) | ||
|
||
[![Create Eclipse Development Environment for Equinox](https://download.eclipse.org/oomph/www/setups/svg/Equinox.svg)](https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-equinox/equinox/master/equinox/org.eclipse.equinox.releng/EquinoxConfiguration.setup&show=true "Click to open Eclipse-Installer Auto Launch or drag into your running installer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@merks can you tell if there is already a manual for beginners how to use/apply an Oomph setup at a common location? I don't think it sustainable to repeat the steps in each repo, like it is for example done in m2e:
https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md#%EF%B8%8F-setting-up-the-development-environment-automatically-using-the-eclipse-installer-oomph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally everyone's configuration has a link to this:
Yes, in the wiki I know. 😢
https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning
Indeed it's silly to repeat such instructions everywhere because they all follow the same pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint!
I didn't saw it because the link in the buttons was wrong. 🤦🏽♂️ Good that this is fixed.
Yes, in the wiki I know. 😢
That's sufficient for now. In the future it would be nice to have the instructions for example right at that page in a sub-section or at a place with a better future? I can look into that at another time.
1085855
to
6f7817b
Compare
Add Oomph setup buttons to the bottom of the README and in the CONTRIBUTING.md
6f7817b
to
f25087f
Compare
This PR consists of two parts