Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple equinox launcher+exe build launch config and enhance native build doc #640

Merged

Conversation

HannesWell
Copy link
Member

This PR consists of two parts

  1. Add Maven launch config to build the launcher and exe native binaries
  2. Enhance native build documentation and adjust CONTRIBUTING section

Copy link

github-actions bot commented Jun 9, 2024

Test Results

  660 files  ±0    660 suites  ±0   1h 13m 31s ⏱️ + 1m 52s
2 195 tests ±0  2 148 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 729 runs  ±0  6 586 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 1085855. ± Comparison against base commit a7c0601.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the launcher-build-doc-enhancements branch from 2d54617 to 6274bd7 Compare June 12, 2024 22:24
- Linux:
- GTK development files. The Package `libgtk-3-dev` is sufficient.
- MacOS:
- XCode Command Line Tools (already present in XCode)
Copy link
Member Author

@HannesWell HannesWell Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume to build the Equinox binaries on Mac the requirements are the same as for SWT, as we have discussed in eclipse-platform/eclipse.platform.swt#1174 (comment).
@Phillipus or @HeikoKlare is that correct?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HannesWell Yes, I think so. I've built the binaries on my Mac with just the Command Line Tools installed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@HannesWell HannesWell force-pushed the launcher-build-doc-enhancements branch 3 times, most recently from 81266db to 1085855 Compare June 23, 2024 13:29
CONTRIBUTING.md Outdated

Be sure to search for existing bugs before you create another one. Remember that
contributions are always welcome!

### Setting up the Development Environment automatically, using the Eclipse Installer (Oomph)

[![Create Eclipse Development Environment for Equinox](https://download.eclipse.org/oomph/www/setups/svg/Equinox.svg)](https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-equinox/equinox/master/equinox/org.eclipse.equinox.releng/EquinoxConfiguration.setup&show=true "Click to open Eclipse-Installer Auto Launch or drag into your running installer")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merks can you tell if there is already a manual for beginners how to use/apply an Oomph setup at a common location? I don't think it sustainable to repeat the steps in each repo, like it is for example done in m2e:
https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md#%EF%B8%8F-setting-up-the-development-environment-automatically-using-the-eclipse-installer-oomph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally everyone's configuration has a link to this:

image

Yes, in the wiki I know. 😢

https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning

Indeed it's silly to repeat such instructions everywhere because they all follow the same pattern.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint!
I didn't saw it because the link in the buttons was wrong. 🤦🏽‍♂️ Good that this is fixed.

Yes, in the wiki I know. 😢

https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning

That's sufficient for now. In the future it would be nice to have the instructions for example right at that page in a sub-section or at a place with a better future? I can look into that at another time.

@HannesWell HannesWell force-pushed the launcher-build-doc-enhancements branch from 1085855 to 6f7817b Compare June 28, 2024 15:57
Add Oomph setup buttons to the bottom of the README and in the
CONTRIBUTING.md
@HannesWell HannesWell force-pushed the launcher-build-doc-enhancements branch from 6f7817b to f25087f Compare June 28, 2024 15:59
@HannesWell HannesWell merged commit 05b2835 into eclipse-equinox:master Jun 28, 2024
8 of 10 checks passed
@HannesWell HannesWell deleted the launcher-build-doc-enhancements branch June 28, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants