Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Derive TARGET_ARCH from -arch argument in make_win64.mak #639

Merged

Conversation

HannesWell
Copy link
Member

This allows cross-compilation on Windows between x86_64 and aarch64 by specifying the -arch argument as usual when calling the win32/build.bat script.

@chirontt do you see any problem with this?

Copy link

github-actions bot commented Jun 9, 2024

Test Results

  660 files  ±0    660 suites  ±0   1h 11m 44s ⏱️ -2s
2 195 tests ±0  2 147 ✅  - 1   47 💤 ±0  1 ❌ +1 
6 729 runs  ±0  6 585 ✅  - 1  143 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 73b0a0c. ± Comparison against base commit 343e816.

♻️ This comment has been updated with latest results.

@chirontt
Copy link
Contributor

Sounds good to me to re-use the -arch argument for cross-compiling purpose. This removes the need to set a TARGET_ARCH environment variable for cross-compiling, as originally intended.

But cross-compiling also requires a target JDK for the relevant headers and/or libraries suitable for the target architecture. Can the -java argument be used for this purpose?

@HannesWell HannesWell force-pushed the simplify-cross-compiling-windows branch from e8634e5 to 8e132ae Compare June 12, 2024 20:54
@HannesWell
Copy link
Member Author

Sounds good to me to re-use the -arch argument for cross-compiling purpose. This removes the need to set a TARGET_ARCH environment variable for cross-compiling, as originally intended.

Exactly. And it also verifies that the jdk passed with the -java argument exists.

But cross-compiling also requires a target JDK for the relevant headers and/or libraries suitable for the target architecture. Can the -java argument be used for this purpose?

That's also right and yes the -java argument can be used for that.
I'm currently enhancing the documentation about how to build the Equinox binaries in #640 and mentioned in there as an example.

@HannesWell HannesWell force-pushed the simplify-cross-compiling-windows branch 6 times, most recently from 1670def to 11154da Compare June 13, 2024 18:37
This allows cross-compilation on Windows between x86_64 and aarch64 by
specifying the -arch argument as usual when calling the
win32/build.bat script.
@HannesWell HannesWell force-pushed the simplify-cross-compiling-windows branch from 11154da to 73b0a0c Compare June 13, 2024 19:18
@HannesWell
Copy link
Member Author

Build is green now (besides the usual TCK failure and an occasional DS test failure).

@HannesWell HannesWell merged commit c5d0146 into eclipse-equinox:master Jun 13, 2024
25 of 27 checks passed
@HannesWell HannesWell deleted the simplify-cross-compiling-windows branch June 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants