Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{math}[foss/2018b] Pyomo v5.5.0 w/ Python 2.7.15 #6910

Merged
merged 5 commits into from
Sep 27, 2018

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Sep 25, 2018

(created using eb --new-pr)

@boegel boegel changed the title {math}[foss/2018b] Pyomo v5.5.0 {math}[foss/2018b] Pyomo v5.5.0 w/ Python 2.7.15 Sep 25, 2018

exts_defaultclass = 'PythonPackage'

exts_download_dep_fail = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please also set use_pip = True, you can do both at once with:

exts_default_options = {
  'download_dep_fail': True,
  'use_pip': True,
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: don't blindly copy code from @boegel without checking for style :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use --check-contrib (new in EasyBuild v3.7.0).

We should probably integrate that with --new-pr & --update-pr, to run style checks locally if at all possible (requires addtional Python packages though...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip!

@boegel boegel added this to the 3.7.1 milestone Sep 25, 2018
@boegel boegel added the new label Sep 25, 2018
@easybuilders easybuilders deleted a comment from boegelbot Sep 26, 2018
@boegel
Copy link
Member

boegel commented Sep 26, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2091.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/6c5f0097a0713fddfc1225bb3225d977 for a full test report.

@smoors
Copy link
Contributor Author

smoors commented Sep 26, 2018

when installing PyUtilib with pip, there is one __init__.py file that is not copied over.

@boegel
Copy link
Member

boegel commented Sep 26, 2018

@smoors I guess it's worth reporting that issue upstream?

@boegel
Copy link
Member

boegel commented Sep 26, 2018

@smoors Hmm, it's quite strange there's a problem when installing PyUtilib with pip, since that's the officially recommended way of installing it, see https://github.com/PyUtilib/pyutilib.

Which __init__ file is missing exactly?

@smoors
Copy link
Contributor Author

smoors commented Sep 26, 2018

@boegel its the base file: pyutilib/__init__.py
I suspect it occurs when installing with --prefix, similar to this:
hpcugent/vsc-install#68

@boegel
Copy link
Member

boegel commented Sep 26, 2018

@smoors You're probably right, see also pypa/pip#1924 where the pip maintainers basically say they won't fix this problem for Python packages using namespaces for Python 2.x & old Python 3.x versions.

Still, this should be reported upstream via https://github.com/PyUtilib/pyutilib/issues, to make sure they're aware of this problem, to ask what a proper workaround would be, and to hear their thoughts on it?

We can probably work around this easily by doing touch %(installdir)s/lib/python2.7/site-packages/PyUtilib-*.egg/pyutilib/__init__.py (but then we should also make sure PyUtilib is fully functional by doing additional sanity checks).

When installing with setuptools, the pyutilib/__init__.py that is installed is not empty, but the stuff in there (like pkg_resources.declare_namespace, etc.) is only relevant when you're spreading the pyutilib namespace across multiple different subdirectories (which is not the case when it's installed...).

@smoors
Copy link
Contributor Author

smoors commented Sep 26, 2018

@boegel I filed an issue, see PyUtilib/pyutilib#39.

not only pyutilib/__init__.py is missing, also pyutilib/component/__init__.py and possibly others (I did not check).

since it works with setuptools, do you think it is really worth the effort to workaround and test just for pip?

@boegel
Copy link
Member

boegel commented Sep 27, 2018

@smoors We're pushing for using pip a bit because i) it's the recommended Python installation tool (see https://packaging.python.org/tutorials/installing-packages/), ii) we would like to start using it by default in PythonPackage soon (cfr. easybuilders/easybuild#447).

This doesn't need to be a blocker for this PR though, since it's clear the problem is not on our side, but with pip.

('PyUtilib', '5.6.3', {
'source_urls': ['https://pypi.python.org/packages/source/p/pyutilib'],
'checksums': ['6a21fccfe691c39566c0bb19b5c9aa11bca8b076aa6f1dbf21c11711f5105191'],
'use_pip': False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please add a comment above this line referencing to PyUtilib/pyutilib#39 to clarify why this is required.

@boegel
Copy link
Member

boegel commented Sep 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5b7ce4f769da52b8f73340faae930456 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3106.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/7b8a63ef1eb4fa2d9ff7d1b061616457 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2723.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/0e0ef6443b05637a2112f2561a561d80 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 27, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 786c941 into easybuilders:develop Sep 27, 2018
@smoors smoors deleted the 20180925142157_new_pr_Pyomo550 branch January 27, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants