-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{math}[foss/2018b] Pyomo v5.5.0 w/ Python 2.7.15 #6910
{math}[foss/2018b] Pyomo v5.5.0 w/ Python 2.7.15 #6910
Conversation
|
||
exts_defaultclass = 'PythonPackage' | ||
|
||
exts_download_dep_fail = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoors Please also set use_pip = True
, you can do both at once with:
exts_default_options = {
'download_dep_fail': True,
'use_pip': True,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: don't blindly copy code from @boegel without checking for style :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use --check-contrib
(new in EasyBuild v3.7.0).
We should probably integrate that with --new-pr
& --update-pr
, to run style checks locally if at all possible (requires addtional Python packages though...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tip!
Test report by @boegel |
when installing PyUtilib with pip, there is one |
@smoors I guess it's worth reporting that issue upstream? |
@smoors Hmm, it's quite strange there's a problem when installing Which |
@boegel its the base file: |
@smoors You're probably right, see also pypa/pip#1924 where the Still, this should be reported upstream via https://github.com/PyUtilib/pyutilib/issues, to make sure they're aware of this problem, to ask what a proper workaround would be, and to hear their thoughts on it? We can probably work around this easily by doing When installing with |
@boegel I filed an issue, see PyUtilib/pyutilib#39. not only since it works with setuptools, do you think it is really worth the effort to workaround and test just for pip? |
@smoors We're pushing for using This doesn't need to be a blocker for this PR though, since it's clear the problem is not on our side, but with |
('PyUtilib', '5.6.3', { | ||
'source_urls': ['https://pypi.python.org/packages/source/p/pyutilib'], | ||
'checksums': ['6a21fccfe691c39566c0bb19b5c9aa11bca8b076aa6f1dbf21c11711f5105191'], | ||
'use_pip': False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoors Please add a comment above this line referencing to PyUtilib/pyutilib#39 to clarify why this is required.
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @smoors! |
(created using
eb --new-pr
)