Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2018b] OptiType v1.3.2 #6924

Merged
merged 3 commits into from
Sep 28, 2018

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Sep 27, 2018

(created using eb --new-pr)

edit: requires #6919 #6910


sanity_check_commands = [(
'cd $EBROOTOPTITYPE && OptiTypePipeline.py -i ./test/exome/NA11995_SRR766010_1_fished.fastq '
'./test/exome/NA11995_SRR766010_2_fished.fastq --dna -v -o ./test/exome/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors OptiType should also work when you're not in the install dir, so we should run this out of the install dir (also to avoid including test output in the installation?)

@boegel boegel added the new label Sep 27, 2018
@easybuilders easybuilders deleted a comment from boegelbot Sep 27, 2018
@boegel
Copy link
Member

boegel commented Sep 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2704.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/aa5b99a5f83cef93533bd6d56bb2992e for a full test report.

}

sanity_check_commands = [(
'OptiTypePipeline.py -i $EBROOTOPTITYPE/test/exome/NA11995_SRR766010_1_fished.fastq '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors I overlooked that sanity check commands are run in the installation directory by default (maybe we need to reconsider that...), which is not a good idea here because of the -o ./.

So, let's add a cd %(builddir)s && before this command?

@boegel
Copy link
Member

boegel commented Sep 28, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/b2ce124f3dab0e397bd85010a0b9dde1 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 28, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2430.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f4e8fa9259339f7a3c0788f15d20193c for a full test report.

@boegel
Copy link
Member

boegel commented Sep 28, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2086.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b1f0675e2695ea2327c1342aec11a286 for a full test report.

@boegel boegel added this to the 3.7.1 milestone Sep 28, 2018
@boegel
Copy link
Member

boegel commented Sep 28, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 78874e7 into easybuilders:develop Sep 28, 2018
@smoors smoors deleted the 20180927162634_new_pr_OptiType132 branch January 27, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants