-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2018b] OptiType v1.3.2 #6924
{bio}[foss/2018b] OptiType v1.3.2 #6924
Conversation
|
||
sanity_check_commands = [( | ||
'cd $EBROOTOPTITYPE && OptiTypePipeline.py -i ./test/exome/NA11995_SRR766010_1_fished.fastq ' | ||
'./test/exome/NA11995_SRR766010_2_fished.fastq --dna -v -o ./test/exome/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoors OptiType
should also work when you're not in the install dir, so we should run this out of the install dir (also to avoid including test output in the installation?)
Test report by @boegel |
} | ||
|
||
sanity_check_commands = [( | ||
'OptiTypePipeline.py -i $EBROOTOPTITYPE/test/exome/NA11995_SRR766010_1_fished.fastq ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoors I overlooked that sanity check commands are run in the installation directory by default (maybe we need to reconsider that...), which is not a good idea here because of the -o ./
.
So, let's add a cd %(builddir)s &&
before this command?
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @smoors! |
(created using
eb --new-pr
)edit: requires
#6919#6910