Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data,math,tools}[GCCcore/13.3.0,foss/2024a,gompi/2024a] gperftools v2.16, HDF5 v1.14.5, HPX v1.10.0 #21570

Merged
merged 11 commits into from
Nov 6, 2024

Conversation

maxim-masterov
Copy link
Collaborator

@maxim-masterov maxim-masterov commented Oct 7, 2024

(created using eb --new-pr)

@maxim-masterov maxim-masterov added the 2024a issues & PRs related to 2024a common toolchains label Oct 9, 2024
@smoors
Copy link
Contributor

smoors commented Oct 19, 2024

@maxim-masterov i moved github_account back to where it belongs, and also changed the sanity_check paths to the original one (using SHLIB_EXT)

please don't change the formatting/structuring just for the sake of it. in most cases there's a good reason why it's done this way.

@smoors
Copy link
Contributor

smoors commented Oct 19, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21570 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21570 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5133

Test results coming soon (I hope)...

- notification for comment with ID 2423773669 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/b43e186395d6d5f885abbbcd7d947bb1 for a full test report.

@smoors
Copy link
Contributor

smoors commented Oct 19, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21570 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21570 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14543

Test results coming soon (I hope)...

- notification for comment with ID 2423798354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e6ce901346d5016a7a7fbaa9a00a6715 for a full test report.

@maxim-masterov
Copy link
Collaborator Author

@maxim-masterov i moved github_account back to where it belongs, and also changed the sanity_check paths to the original one (using SHLIB_EXT)

please don't change the formatting/structuring just for the sake of it. in most cases there's a good reason why it's done this way.

Thanks, I missed that part. I guess it was automatically reformatted by the eb command when I used --try-update-deps and --copy-ec options. I noted it for the later PRs.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.4 milestone Oct 25, 2024
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
skl-rockylinux-810 - Linux Rocky Linux 8.10, x86_64, Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (skylake), 1 x NVIDIA NVIDIA RTX A4000, 555.42.06, Python 3.6.8
See https://gist.github.com/SebastianAchilles/60392c34707b74121529019cb8214e0b for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @maxim-masterov!

@SebastianAchilles SebastianAchilles merged commit a50fb51 into easybuilders:develop Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024a issues & PRs related to 2024a common toolchains new update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants