-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for duplicate PYTHONPATH
in modextrapaths
#19061
Open
Flamefire
wants to merge
4
commits into
easybuilders:5.0.x
Choose a base branch
from
Flamefire:add-test-for-duplicate-pythonpath
base: 5.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add test for duplicate PYTHONPATH
in modextrapaths
#19061
Flamefire
wants to merge
4
commits into
easybuilders:5.0.x
from
Flamefire:add-test-for-duplicate-pythonpath
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boegel Anything missing here? This is a CI test change only so shouldn't cause any regressions for users (but actually helps avoiding them) |
Flamefire
force-pushed
the
add-test-for-duplicate-pythonpath
branch
from
April 16, 2024 10:19
d45f0b6
to
aec46ee
Compare
And similar test for `sanity_check_paths`. Intended to avoid issues fixed in easybuilders#13385
Flamefire
force-pushed
the
add-test-for-duplicate-pythonpath
branch
from
December 19, 2024 08:34
1ef4ac2
to
e4fbb9b
Compare
Retargeted 5.0x |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And similar test for
sanity_check_paths
.Intended to avoid issues fixed in #13385
Edit: Changed to using regexs to catch hard-coded version numbers instead of
%(pyshortver)s
.Example failure using one of the faulty ECs from #13385:
Requires:
to fix the test failure due to unresolved template