Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for duplicate PYTHONPATH in modextrapaths #19061

Open
wants to merge 4 commits into
base: 5.0.x
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Oct 23, 2023

And similar test for sanity_check_paths.

Intended to avoid issues fixed in #13385

Edit: Changed to using regexs to catch hard-coded version numbers instead of %(pyshortver)s.

Example failure using one of the faulty ECs from #13385:

CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: sanity_pip_check should be enabled
CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: modextrapaths contains superflous 'lib/python2.7/site-packages' (automatically added by easyblock)
CIRCexplorer-1.1.10-intel-2017b-Python-2.7.14.eb: sanity_check_paths['dirs'] contains superflous ['lib/python2.7/site-packages'] (automatically added by easyblock)

Requires:

@Flamefire
Copy link
Contributor Author

@boegel Anything missing here? This is a CI test change only so shouldn't cause any regressions for users (but actually helps avoiding them)

@boegel boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024
@Flamefire Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from d45f0b6 to aec46ee Compare April 16, 2024 10:19
@boegel boegel modified the milestones: 4.9.2, release after 4.9.2 Jun 8, 2024
@boegel boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024
@Flamefire Flamefire changed the base branch from develop to 5.0.x December 19, 2024 08:34
@Flamefire Flamefire force-pushed the add-test-for-duplicate-pythonpath branch from 1ef4ac2 to e4fbb9b Compare December 19, 2024 08:34
@Flamefire
Copy link
Contributor Author

Flamefire commented Dec 19, 2024

Retargeted 5.0x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants