-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated PYTHONPATH module entries #13385
Conversation
Test report by @Flamefire Note: Tested all I could, excluded intel-2017 ECs from the test due to license issues |
@boegel Anything required here? |
adaf482
to
c126ebe
Compare
Test report by @Flamefire |
c126ebe
to
9ea766a
Compare
Updated/rebased again and verified with |
@Flamefire All these easyconfigs have already been archived in the Can we enhance the easyconfigs test suite so these duplicated |
Hm, ok
Maybe: #19061 |
Can this be merged? Fixed conflicts again |
And similar test for `sanity_check_paths`. Intended to avoid issues fixed in easybuilders#13385
Found via `grep -E ": 'lib/python[^/]+/site-packages'" $(grep --files-with-matches -Er "\\beasyblock = '(ConfigureMakePythonPackage|PythonBundle)'")`
434cd10
to
602e0bd
Compare
Closing for #20960 |
And similar test for `sanity_check_paths`. Intended to avoid issues fixed in easybuilders#13385
Those ECs set the PYTHONPATH again which is already done by the used easyblock leading to a slower module/python
Running into #13432 while testing this, hence fixed here
Fixes #13432