Dashboard rewrite updates #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 13, 2023 09:47
google translate, tracked in a spreadsheet to send off for verification
forgot to translate something in lo.json
we've moved away from showing "calories burned in active travel" and started to show "minutes spent in active travel" Therefore, we no longer need the keys about calories, calibrating to user date (already left profile) or comparing the calories to food.
|
@Abby-Wheelis doesn't this need to be merged along with the dashboard updates? |
|
Yes! I was waiting to mark it ready for merge until review on the dashboard in case we decided to change any more strings, or we heard back about updates to the google-translated strings. I can mark it ready now thought, and make any further updates in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the translation files to reflect the dashboard re-write. (📊 Rewrite of the New Dashboard Tab), follow-on to #42, so it would be best if 42 was merged first.
Considerable use of google translate for Lao translations, which I tracked in a spreadsheet as well as the json files for easy verification, I should be able to send that off today.