🐛 Fix timeline range issues #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within one app session, the constants TODAY_DATE and INITIAL_DATE_RANGE do not change. On app resume, we call refreshTimeline which sets dateRange to INITIAL_DATE_RANGE. But this is a problem if the app stays running for multiple days because INITIAL_DATE_RANGE is old. Instead we need to recompute the date range, using an up-to-date "today" date. Thus, TODAY_DATE and INITIAL_DATE_RANGE are replaced with functions: getTodayDate and getPastWeekDateRange.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
+ Coverage 29.42% 29.44% +0.01%
==========================================
Files 122 122
Lines 4910 4915 +5
Branches 1080 1080
==========================================
+ Hits 1445 1447 +2
- Misses 3465 3468 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
For a new user where the pipeline has not yet processed, pipelineRange will be `{ start_ts: null, end_ts: null }`.
We should handle this appropriately:
-in TimelineScrollList, pipelineEndDate should be undefined instead of trying to call DateTime.fromSeconds with null
-loadDateRange should return early and do nothing
-The early return from fetchTripsInRange should return empty arrays, not void
…/e-mission-phone into fix-timeline-refresh
JGreenlee
changed the title
shankari
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on timeline refresh, recompute "past week" date range
Within one app session, the constants TODAY_DATE and INITIAL_DATE_RANGE do not change. On app resume, we call refreshTimeline which sets dateRange to INITIAL_DATE_RANGE. But this is a problem if the app stays running for multiple days because INITIAL_DATE_RANGE is old.
Instead we need to recompute the date range, using an up-to-date "today" date. Thus, TODAY_DATE and INITIAL_DATE_RANGE are replaced with functions: getTodayDate and getPastWeekDateRange.
fix errors on pipelineRange with null start_ts and end_ts
For a new user where the pipeline has not yet processed, pipelineRange will be
{ start_ts: null, end_ts: null }.We should handle this appropriately:
-in TimelineScrollList, pipelineEndDate should be undefined instead of trying to call DateTime.fromSeconds with null
-loadDateRange should return early and do nothing
-The early return from fetchTripsInRange should return empty arrays, not void
fix re-prompting of notifications permission after denied