Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store "HasRequestedNotificationPermission" in native LocalStorage #240

Merged
merged 3 commits into from
Oct 9, 2024
Merged

store "HasRequestedNotificationPermission" in native LocalStorage #240

merged 3 commits into from
Oct 9, 2024

Conversation

JGreenlee
Copy link
Contributor

No description provided.

@JGreenlee JGreenlee force-pushed the store-notification-request branch from d7c6af5 to e062604 Compare October 8, 2024 21:55
@shankari
Catch JSON exception and return an error to get android to compile
1ff879b 
Testing done:

```
$ npx cordova build
** BUILD SUCCEEDED **
```
@shankari shankari force-pushed the store-notification-request branch from cc66591 to 1ff879b Compare October 8, 2024 22:28
@shankari
Copy link
Contributor

shankari commented Oct 8, 2024

@JGreenlee this now compiles on both android and iOS (see my last commit).
Once the phone changes are done, I can pull and test...

@JGreenlee
Copy link
Contributor Author

I put all the bugfixes in e-mission/e-mission-phone#1183

@shankari shankari marked this pull request as ready for review October 9, 2024 03:43
@shankari shankari merged commit 5ca1496 into e-mission:master Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JGreenlee @shankari