Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension loading issue described in #84 #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix extension loading issue described in #84 #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/iceberg_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
namespace duckdb {

static void LoadInternal(DatabaseInstance &instance) {
auto &config = DBConfig::GetConfig(instance);

config.AddExtensionOption(
"unsafe_enable_version_guessing",
"Enable globbing the filesystem (if possible) to find the latest version metadata. This could result in reading an uncommitted version.",
LogicalType::BOOLEAN,
Value::BOOLEAN(false)
);

// Iceberg Table Functions
for (auto &fun : IcebergFunctions::GetTableFunctions()) {
ExtensionUtil::RegisterFunction(instance, fun);
Expand All @@ -28,14 +37,6 @@ static void LoadInternal(DatabaseInstance &instance) {
}

void IcebergExtension::Load(DuckDB &db) {
auto &config = DBConfig::GetConfig(*db.instance);

config.AddExtensionOption(
"unsafe_enable_version_guessing",
"Enable globbing the filesystem (if possible) to find the latest version metadata. This could result in reading an uncommitted version.",
LogicalType::BOOLEAN,
Value::BOOLEAN(false)
);
LoadInternal(*db.instance);
}
std::string IcebergExtension::Name() {
Expand Down
Loading