Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function where new config value is defined #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teaguesterling
Copy link
Contributor

@teaguesterling teaguesterling commented Dec 26, 2024

This should fix #84 by changing where the unsafe_enable_version_guessing config value is defined to the same function where other new functions are defined. This has been tested by the following:

~/duckdb_iceberg$ make test
...
cd
~/$ duckdb -unsigned
D FORCE INSTALL 'duckdb_iceberg/build/release/repository/v1.1.3/linux_amd64/iceberg.duckdb_extension';
D LOAD iceberg;
D .quit
cd ~/duckdb_iceberg/data/iceberg
~/duckdb_iceberg/data/iceberg$ duckdb -unsigned # note this is my system version of duckdb
D LOAD iceberg;
D SET unsafe_enable_version_guessing=true;
D SELECT COUNT() FROM iceberg_scan('lineitem_iceberg_no_hint');
┌──────────────┐
│ count_star() │
│    int64     │
├──────────────┤
│        51793 │
└──────────────┘

Signed-off-by: Teague Sterling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SET unsafe_enable_version_guessing=true does not work with duckdb 1.1.3
1 participant