Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoload('parquet') since it's needed for scan_parquet #115

Merged
merged 1 commit into from
Nov 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/functions/delta_scan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "duckdb/common/types/data_chunk.hpp"
#include "duckdb/execution/expression_executor.hpp"
#include "duckdb/function/table_function.hpp"
#include "duckdb/main/extension_helper.hpp"
#include "duckdb/main/extension_util.hpp"
#include "duckdb/main/secret/secret_manager.hpp"
#include "duckdb/optimizer/filter_combiner.hpp"
Expand Down Expand Up @@ -937,9 +938,11 @@ bool DeltaMultiFileReader::ParseOption(const string &key, const Value &val, Mult
//}

TableFunctionSet DeltaFunctions::GetDeltaScanFunction(DatabaseInstance &instance) {
// Parquet extension needs to be loaded for this to make sense
ExtensionHelper::AutoLoadExtension(instance, "parquet");

// The delta_scan function is constructed by grabbing the parquet scan from the Catalog, then injecting the
// DeltaMultiFileReader into it to create a Delta-based multi file read

auto &parquet_scan = ExtensionUtil::GetTableFunction(instance, "parquet_scan");
auto parquet_scan_copy = parquet_scan.functions;

Expand Down
Loading