Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoload('parquet') since it's needed for scan_parquet #115

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Nov 11, 2024

In case of duckdb-wasm (potentially also in other configurations) parquet might not be already loaded.

This makes so that in those cases error change from:

LOAD delta;
Invalid Input Error: Initialization function "delta_init" from file "/Users/carlo/.duckdb/extensions/v1.1.3/osx_arm64/delta.duckdb_extension" threw an exception: "Function with name "parquet_scan" not found in ExtensionUtil::GetTableFunction"

to either successfully autoinstalling or autoloading parquet OR informing that there has been an autoloading problem with the parquet extension.

This is minor, and should not change any currently tested code-path.

@carlopi carlopi force-pushed the parquet_autoloading branch from dcf141c to 4740aa1 Compare November 11, 2024 15:00
@carlopi carlopi force-pushed the parquet_autoloading branch from 4740aa1 to 3cfc758 Compare November 11, 2024 15:23
@samansmink
Copy link
Collaborator

Looks good, thanks!

@samansmink samansmink merged commit 6c4fcaf into duckdb:main Nov 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants