-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve model definition ui #29
Conversation
Now the example model tests pass! |
Now all the tests pass! |
Changed balanced_ids to balanced_species in KineticModelSbml
Oops, thanks @AlberteSloth! |
"r3": jnp.array(0.1), | ||
}, | ||
dgf=jnp.array([-3.0, -1.0]), | ||
log_ki={"r1": jnp.array([]), "r2": jnp.array([1.0]), "r3": jnp.array([])}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need to specify the index of the balanced metabolites for the ui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently it just has to agree with the order of balanced_species
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This change makes it easier to define a kinetic model. Now you can create one from scratch like this (believe it or not, this is a big improvement!):
There is still a lot of room to make things easier. In particular it should be possible to create the parameter definition automatically from the structure. There should also be helpful validation of the parameters.
Checklist:
README.md
up to date