-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2673 sonarqube beta3 namespace #2831
Conversation
…qube_beta3_namespace
…qube_beta3_namespace
Thank you for this work, @hsoh-u. Would you say that this PR also covers the work described in this issue Move namespace specifications below include directives #2696? If so, let's link in this issue under "Development" as well, and thanks for doing the work I had planned to do, but had not gotten to yet! |
Added it to "Expected Differences". I can not add #2696 to Development. Typing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsoh-u, thank you for your work on this and for running the unit tests and comparing the output of the nighty build. Thank you also for noting that a few cases are not fixed and that they may be generated code. I'm not sure what the problem was with adding #2696 to "Development", but I was able to add it without any trouble. Thanks for adding it to Expected Difference, in case we couldn't get it to work. I approve this pull request.
Expected Differences
Moved down the
using namespace
statements below#include
statements at*cc
files (Move namespace specifications below include directives #2696 ).Removed "using namespace" statements from header files (Move namespace specifications below include directives #2696 )
Added the namespace into header files, for example (
string
tostd::string
)Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Ran the unit test and compare the output of the nighty build
Checking
using namespace
statement at the header filesFew cases are not fixed. They may be the generated codes.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases