Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2673 sonarqube beta3 namespace #2831

Merged
merged 13 commits into from
Mar 6, 2024

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 5, 2024

Expected Differences

  • Moved down the using namespace statements below #include statements at *cc files (Move namespace specifications below include directives #2696 ).

  • Removed "using namespace" statements from header files (Move namespace specifications below include directives #2696 )

  • Added the namespace into header files, for example (string to std::string)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran the unit test and compare the output of the nighty build

Checking using namespace statement at the header files

 find src -type f -name "*h" -o -name "*hpp"  -exec grep -nH -A 4 "using namespace" {} \;

Few cases are not fixed. They may be the generated codes.

find src -type f -name "*h" -o -name "*hpp" -o -name "*cc"  -exec grep -nH -A 4 "using namespace" {} \; | grep include |  less
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u requested a review from jprestop March 5, 2024 19:13
@hsoh-u hsoh-u linked an issue Mar 5, 2024 that may be closed by this pull request
21 tasks
@jprestop
Copy link
Collaborator

jprestop commented Mar 6, 2024

Thank you for this work, @hsoh-u. Would you say that this PR also covers the work described in this issue Move namespace specifications below include directives #2696? If so, let's link in this issue under "Development" as well, and thanks for doing the work I had planned to do, but had not gotten to yet!

@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Mar 6, 2024

Added it to "Expected Differences". I can not add #2696 to Development. Typing 269 shows 2697 only and typing move does not work.

@jprestop jprestop linked an issue Mar 6, 2024 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u, thank you for your work on this and for running the unit tests and comparing the output of the nighty build. Thank you also for noting that a few cases are not fixed and that they may be generated code. I'm not sure what the problem was with adding #2696 to "Development", but I was able to add it without any trouble. Thanks for adding it to Expected Difference, in case we couldn't get it to work. I approve this pull request.

@hsoh-u hsoh-u merged commit 0b2a7da into develop Mar 6, 2024
37 checks passed
@hsoh-u hsoh-u deleted the feature_2673_sonarqube_beta3_namespace branch March 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Move namespace specifications below include directives Fix the SonarQube findings for MET version 12.0.0
2 participants