Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespace specifications below include directives #2696

Closed
8 of 22 tasks
jprestop opened this issue Sep 28, 2023 · 1 comment · Fixed by #2831
Closed
8 of 22 tasks

Move namespace specifications below include directives #2696

jprestop opened this issue Sep 28, 2023 · 1 comment · Fixed by #2831
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@jprestop
Copy link
Collaborator

Describe the Task

This issue arose from this comment on a previous pull request where we were tasked with removing the namespace specification from heater files. It was noted that best practice indicates that namespace specifications should be in the implementation files after any #include directives. This task is to move the namespace specifications below include directives.

Time Estimate

1-3 days of work

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

none

Funding Source

TBD

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added component: code cleanup Code cleanup and maintenance issue type: task An actionable item of work priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team labels Sep 28, 2023
@jprestop jprestop added this to the MET 12.0.0 milestone Sep 28, 2023
@jprestop jprestop self-assigned this Sep 28, 2023
@jprestop jprestop changed the title Code cleanup: Move namespace specifications below include directives Move namespace specifications below include directives Sep 28, 2023
@hsoh-u hsoh-u moved this from 🔖 Ready to 🏗 In progress in MET-12.0.0 Development Mar 6, 2024
@jprestop jprestop linked a pull request Mar 6, 2024 that will close this issue
15 tasks
@jprestop
Copy link
Collaborator Author

jprestop commented Mar 6, 2024

The work was done in with this PR: #2831

@jprestop jprestop closed this as completed Mar 6, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in MET-12.0.0 Development Mar 6, 2024
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants