-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply standard JSON format to DDFs #8021
Apply standard JSON format to DDFs #8021
Conversation
Hey @bluemoehre, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
ValidationTip Everything is fine ! 🕖 Updated for commit a945287 |
4b17c19
to
ba34a4c
Compare
cef4897
to
eaf85f5
Compare
@manup here we go with the real code formatting. Approx read time: 15min (but its just once in a lifetime - hopefully ;) |
eaf85f5
to
a945287
Compare
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕞 Updated for commit 0d730c0 |
I was skeptical if by merging this the other large PR #7979 would get conflicts but a local merge test worked just fine. |
I was also worried that this would cause a headache somewhere because the PR has already aged a bit. Refactoring PRs may get complicated over time. |
This is a follow-up of #8019 and should be merged afterwards to simplify the review process.
This PR fixes:
… by applying the Standard JSON Format.
This PR does not fix:
… because there is no consistent pattern and applying the default alphanumeric order will lead to hard readable files.
Note
No code contents were harmed in this PR 🐶