RE: DDF for Tuya trv: Essentials, Revolt, Siterwell, Nedis...

[mattreim]

Reopened #7640

My test device:
Essentials 12011

The information is from the following page zha-device-handlers.

Phoscon:

[mattreim]

Hey @Smanar, the first error has been fixed and the next one is coming and I can't find him.

[Smanar]

Me too, I have checked your json, no typo on my side, it work

@Zehir what is the json problem ?

[Zehir]

Hello @Smanar , it's not the json format the issue, I need to update the error message.

The correct error is : There is no generic file for config/setvalve

[mattreim]

I had already done a PR there and closed two weeks ago. Should I open it again?

[Zehir]

@manup @SwoopX Any idea about that ?

[mattreim]

But with "public: true" it works and I can also control it externally.

[Smanar]

There is no generic file for config/setvalve

@mattreim you need a json file in devices\generic\items called config_setvalve_item.json with this contain

{
  "schema": "resourceitem1.schema.json",
  "id": "config/setvalve",
  "datatype": "Bool",
  "access": "RW",
  "public": true,
  "description": "XXXXXXXXXXXXXXXXXXXxx.",
  "default": false
}

And yes it can work without this file, but the github bot want this file ^^

[mattreim]

@Smanar Please take a look at #7614. I reopened it.

[Smanar]

Ha yes ...
So wich one name you want instead of config/setvalve @SwoopX and @manup

Or he can give up and just remove this field from his DDF ?

[mattreim]

I asked to rename it but the effort would be too high. I don't think it's a good idea to remove it because it's quite important and useful for use.

[SwoopX]

@manup @SwoopX Any idea about that ?

@Zehir Well, the json file for that item is indeed missing and was apparently forgotten during its introduction

[mattreim]

@Zehir config_setvalve_item.json is now merged.

[Zehir]

@Zehir config_setvalve_item.json is now merged.

Then you need to rebase this PR on the latest commit from the main branch

[mattreim]

@Zehir Now comes the next error

[Zehir]

@Zehir Now comes the next error

It's not related to this PR but there is issue on the main branch, checking with other devs. Maybe related to #7961

[Zehir]

Fix was added in #7979

[mattreim]

Now it works, thank you all.

[github-actions]

Hey @mattreim, thanks for your pull request!

Tip

Modified bundles can be downloaded here.

DDB changes

Modified

• tuya/_TZE200_TYST11_trv.json : Tuya radiator thermostat ✔️

Validation

Tip

Everything is fine !

_{🕥 Updated for commit 068b2da}

[mattreim]

@Smanar @manup Unbelievable now it's broken again and now what?

[Smanar]

Arf, sorry , it's because this PR #8021
He have modified all files, and yours too.
But the change is minimal, I think it will be easy to correct it, the PR just changes synthax.

Clic on the "Resolve Conflits" button (just below), it will open a text editor on the browser with both version (the master and yours, mixed on the same file), just correct the problematic lines, there is no check after, it will just ask you if you have corrected, if you said "yes", the conflict will be removed.

[mattreim]

Unfortunately the "Resolve Conflits" button is grayed out. Now there are only two options: I open a new PR again or someone (e.g. @manup) with write rights deletes this file.

devices/tuya/_TZE200_hhrtiq0x_nedis_trv.json