Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Cross-site scripting in username edit field (✓ Sandbox Passed) #315

Closed
wants to merge 8 commits into from
Closed

Sweep: Cross-site scripting in username edit field (✓ Sandbox Passed) #315

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88441f5
feat: Add sanitizeInput utility function to preven
sweep-ai[bot] Feb 18, 2024
6dca10c
feat: Updated src/components/common/EditableSpan.j
sweep-ai[bot] Feb 18, 2024
e484411
feat: Updated src/components/common/EditableSpan.j
sweep-ai[bot] Feb 18, 2024
b8ff5ed
Update src/components/common/EditableSpan.js
stevenhao Feb 20, 2024
114e92d
feat: Updated src/components/common/EditableSpan.j
sweep-ai[bot] Feb 20, 2024
5c00f5f
Merge main into sweep/crosssite_scripting_in_username_edit_fie
sweep-ai[bot] Apr 9, 2024
82dc3ef
Merge main into sweep/crosssite_scripting_in_username_edit_fie
sweep-ai[bot] Apr 25, 2024
1a7753a
Merge main into sweep/crosssite_scripting_in_username_edit_fie
sweep-ai[bot] Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/common/EditableSpan.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import './css/editableSpan.css';
import React, {PureComponent} from 'react';
import _ from 'lodash';
import Caret from '../../lib/caret';
import { sanitizeInput } from '../../utils/sanitizeInput';

export default class EditableSpan extends PureComponent {
constructor() {
Expand Down Expand Up @@ -48,6 +49,7 @@ export default class EditableSpan extends PureComponent {
let result = value;
const nbsp = String.fromCharCode('160');
while (result.indexOf(' ') !== -1) {
import { sanitizeInput } from '../../utils/sanitizeInput';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this import statement where it belongs

Copy link
Author

@sweep-ai sweep-ai bot Feb 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wrote Changes

Done.

This is an automated message generated by Sweep AI.

stevenhao marked this conversation as resolved.
Show resolved Hide resolved
result = result.replace(' ', nbsp);
}
return result;
Expand All @@ -69,7 +71,7 @@ export default class EditableSpan extends PureComponent {
if (this.props.hidden) return;
if (this.text === val) return;
// set text while retaining cursor position
this.span.current.innerHTML = val;
this.span.current.innerHTML = sanitizeInput(val);
}

handleFocus = () => {
Expand Down
3 changes: 3 additions & 0 deletions src/utils/sanitizeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function sanitizeInput(input) {
return input.replace(/<\/?[^>]+(>|$)/g, "");
}