Sweep: Cross-site scripting in username edit field (✓ Sandbox Passed) #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Rollback Files For Sweep
This is an automated message generated by Sweep AI. |
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stevenhao
reviewed
Feb 18, 2024
| @@ -48,6 +48,7 @@ export default class EditableSpan extends PureComponent { | |||
| let result = value; | |||
| const nbsp = String.fromCharCode('160'); | |||
| while (result.indexOf(' ') !== -1) { | |||
| import { sanitizeInput } from '../../utils/sanitizeInput'; | |||
There was a problem hiding this comment.
can you put this import statement where it belongs
There was a problem hiding this comment.
stevenhao
reviewed
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This pull request addresses a cross-site scripting vulnerability in the username edit field of the application. It introduces a new utility function
sanitizeInputin thesanitizeInput.jsfile to sanitize user input and prevent the execution of malicious code.Summary
sanitizeInputfunction insanitizeInput.jsto sanitize user input and prevent cross-site scripting attacks.EditableSpan.jsin thesrc/components/commondirectory:sanitizeInputfunction fromsanitizeInput.js.replacemethod in thesanitizefunction to usesanitizeInputfor sanitizing user input.handleTextChangemethod.handleFocusmethod to use thesanitizeInputfunction for sanitizing user input.Please review and merge this pull request to address the identified security vulnerability.
Fixes #314.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: