Skip to content

Commit

Permalink
Lint, no cli tests
Browse files Browse the repository at this point in the history
  • Loading branch information
steinitzu committed Sep 6, 2024
1 parent 911113e commit b9b317a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_sqlalchemy_destinations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
run: pwd && echo "$DLT_SECRETS_TOML" > tests/.dlt/secrets.toml

# always run full suite, also on branches
- run: poetry run pytest tests/load tests/cli -x
- run: poetry run pytest tests/load -x
name: Run tests Linux
env:
DESTINATION__SQLALCHEMY_MYSQL__CREDENTIALS: mysql://root:[email protected]:3306/dlt_data # Use root cause we need to create databases
Expand Down
7 changes: 6 additions & 1 deletion dlt/destinations/impl/sqlalchemy/configuration.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, Optional, Any, Final, Type, Dict
from typing import TYPE_CHECKING, Optional, Any, Final, Type, Dict, Union
import dataclasses

from dlt.common.configuration import configspec
Expand All @@ -16,6 +16,11 @@ class SqlalchemyCredentials(ConnectionStringCredentials):

username: Optional[str] = None # e.g. sqlite doesn't need username

def __init__(
self, connection_string: Optional[Union[str, Dict[str, Any], "Engine"]] = None
) -> None:
super().__init__(connection_string) # type: ignore[arg-type]

def parse_native_representation(self, native_value: Any) -> None:
from sqlalchemy.engine import Engine

Expand Down
2 changes: 1 addition & 1 deletion tests/cases.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import datetime
import datetime # noqa: I251
import hashlib
from typing import Dict, List, Any, Sequence, Tuple, Literal, Union
import base64
Expand Down

0 comments on commit b9b317a

Please sign in to comment.