Skip to content

Commit

Permalink
Test on sqlalchemy 1.4 and 2
Browse files Browse the repository at this point in the history
remove secrets toml

remove secrets toml

Revert "remove secrets toml"

This reverts commit 7dd189c.

Fix default pipeline name test
  • Loading branch information
steinitzu committed Sep 6, 2024
1 parent b89077d commit 911113e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/test_sqlalchemy_destinations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ jobs:
if: needs.get_docs_changes.outputs.changes_outside_docs == 'true'
strategy:
fail-fast: false
# Run on sqlalchemy 1.4 and 2.0
matrix:
sqlalchemy: [1.4, 2]
defaults:
run:
shell: bash
Expand Down Expand Up @@ -83,7 +86,7 @@ jobs:
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('**/poetry.lock') }}-local-destinations

- name: Install dependencies
run: poetry install --no-interaction -E parquet -E filesystem -E sqlalchemy -E cli --with sentry-sdk --with pipeline && poetry run pip install mysqlclient
run: poetry install --no-interaction -E parquet -E filesystem -E sqlalchemy -E cli --with sentry-sdk --with pipeline && poetry run pip install mysqlclient && poetry run pip install "sqlalchemy==${{ matrix.sqlalchemy }}"

- name: create secrets.toml
run: pwd && echo "$DLT_SECRETS_TOML" > tests/.dlt/secrets.toml
Expand Down
2 changes: 1 addition & 1 deletion tests/load/pipeline/test_pipelines.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def data_fun() -> Iterator[Any]:
# mock the correct destinations (never do that in normal code)
with p.managed_state():
p._set_destinations(
destination=Destination.from_reference(destination_config.destination_type),
destination=destination_config.destination_factory(),
staging=(
Destination.from_reference(destination_config.staging)
if destination_config.staging
Expand Down

0 comments on commit 911113e

Please sign in to comment.