Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/3-bit #127

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Feat/3-bit #127

merged 5 commits into from
Dec 18, 2024

Conversation

dovgopoly
Copy link
Member

  • Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@dovgopoly dovgopoly requested a review from Arvolear December 17, 2024 19:22
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.72%. Comparing base (3585f10) to head (ab87520).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
contracts/libs/crypto/ECDSA384.sol 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   99.75%   99.72%   -0.03%     
==========================================
  Files          56       56              
  Lines        3278     3301      +23     
  Branches      489      495       +6     
==========================================
+ Hits         3270     3292      +22     
- Misses          8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 420d9dc into master Dec 18, 2024
3 of 4 checks passed
@Arvolear Arvolear deleted the feat/3bit branch December 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negatives in ECDSA384.sol Inner Double Scalar Mul edge case.
2 participants