Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inner Double Scalar Mul edge case. #125

Closed
rdubois-crypto opened this issue Dec 15, 2024 · 0 comments · Fixed by #127
Closed

Inner Double Scalar Mul edge case. #125

rdubois-crypto opened this issue Dec 15, 2024 · 0 comments · Fixed by #127
Assignees
@Arvolear
Labels
bug Something isn't working

Comments

@rdubois-crypto
Copy link

rdubois-crypto commented Dec 15, 2024 •
edited
Loading

Solarity version

v2.7.14

What happened?

AddAffine implicitely assumes that input point are different. Function will return incorrect output if P==Q.

As such testing equality is required by the callee.

Minimal reproduction steps

Input a Shamir's edge case such that P==Q in inner loop.
@rdubois-crypto rdubois-crypto added the bug Something isn't working label Dec 15, 2024
@hack3r-0m hack3r-0m mentioned this issue Dec 16, 2024
Closed
@Arvolear Arvolear linked a pull request Dec 18, 2024 that will close this issue
Feat/3-bit #127
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arvolear Arvolear

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/3-bit dl-solarity/solidity-lib
2 participants
@Arvolear @rdubois-crypto