-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin dashboard updates #429
Merged
Merged
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3068d29
change center to africa
czue fbbafd1
add ability to enable/disable clustering by url param
czue 1d06e14
wip: switch to chart clusters
czue 7720e2f
cleanup
czue 6ee83a5
cleanup
czue 1bbdd80
delete unused click handler
czue 3a57fe5
format file
czue 9ccadbb
wip: loading state
czue 447bd62
debug statements
czue f3026d3
improve set data / loading issues
czue 8455804
style tweaks
czue 4bae7e3
remove cluster argument
czue 882c2aa
fix formatting
czue cb1d729
consistent colors
czue 08a6f31
better comments
czue 6b18685
default to only 30 days of data
czue b164959
whitespace
czue 2d8cd8f
add minimum cluster size
czue 8896d5f
increase maxZoom
czue 91f0f0b
extract some functions to external javascript
czue 4b30441
extract updateMarkers
czue ee37856
remove logging statments
czue 8330b10
fix tests
czue fa092aa
put map in a container
czue f64430a
dummy chart implementation
czue c9c76c6
fix sizing, responsiveness
czue aabb39f
smaller cluster radius
czue bcce9ac
add api for graphs
czue 1cc46a3
get program breakdown kinda working
czue 38e0f13
add "unknown" label
czue 19870ab
improve color overlaps
czue f5746e5
make it a bar chart
czue ac9ac10
mock out spots for pie charts
czue 2eb33e0
implement pie charts
czue 14be29b
style tweaks
czue 6748eae
use a better name
czue c02a374
refactor each chart to its own function
czue 684143e
add doc strings
czue fb11e70
externalize js to js file
czue 9a426ce
add better empty states
czue 89893bc
Merge pull request #431 from dimagi/cz/charts
czue 4ad4ac4
Merge branch 'main' into cz/dashboard-tweaks
czue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How confident are you that you want
UserVisit
rather thanCompletedWork
(user visits can be combined to form a single completed work, which is the unit of payment). I think we typically view Completed Works as a unit of delivery instead of the form, since it can account for things a visit that includes 2 forms filled out at the same time that together mark a delivery.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all using the same base queryset which I got from the superset dashboard's SQL, so I think it's right? Or at least, it's consistent with the superset view and itself.
But can definitely revisit this logic once the dashboard has been vetted by the team more.