-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin dashboard updates #429
Conversation
I don't think the build failure is related, though let me know if I should look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admittedly didn't look too closely at the JS but the rest looks fine. One question
@user_passes_test(lambda u: u.is_superuser) | ||
def dashboard_charts_api(request): | ||
filterset = DashboardFilters(request.GET) | ||
queryset = UserVisit.objects.all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How confident are you that you want UserVisit
rather than CompletedWork
(user visits can be combined to form a single completed work, which is the unit of payment). I think we typically view Completed Works as a unit of delivery instead of the form, since it can account for things a visit that includes 2 forms filled out at the same time that together mark a delivery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all using the same base queryset which I got from the superset dashboard's SQL, so I think it's right? Or at least, it's consistent with the superset view and itself.
But can definitely revisit this logic once the dashboard has been vetted by the team more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to approve and I think "requesting changes" is the only way I can get back to a not approved state, but depending on the answer to the question will approve again.
New Screenshot:
Changes:
(recommend reviewing all at once)