Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eslint with biomejs #2189

Merged
merged 39 commits into from
Aug 1, 2024
Merged

chore: replace eslint with biomejs #2189

merged 39 commits into from
Aug 1, 2024

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Jul 29, 2024

TLDR; Replace eslint and prettier (except css) for linting and formatting.

After doing some testing, debugging and fighting with getting eslint to work in #2175, I made this to test biomejs as a replacement.

Either way we had to do big config changes for eslint 9.x so might aswell try biomejs.

In general a positive experience having tested biomejs.

Noticable changes:

  • Linting is now done for the whole repo, except "ignores".
  • Seperated gh workflows.
    • Linting is now done in a separate workflow for the whole repo.
    • Building and testing the individual packages or apps i their own workflow. (will do more renames here after merging into next)
  • New recommended vscode extension for biomejs.

Biomejs vs Eslint

@mimarz mimarz requested a review from Barsnes as a code owner July 29, 2024 13:13
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 268370d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Preview deployments for this pull request:

📖 Storybook 1. Aug 2024 - 14:36 (Norwegian time)

🖥 Storefront 1. Aug 2024 - 14:37 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mimarz mimarz changed the title chore: Use biomejs chore: use biomejs Jul 29, 2024
@mimarz mimarz changed the title chore: use biomejs chore: Replace eslint with biomejs Jul 31, 2024
@mimarz mimarz changed the title chore: Replace eslint with biomejs chore: replace eslint with biomejs Jul 31, 2024
@mimarz mimarz merged commit 6959e9d into next Aug 1, 2024
7 checks passed
@mimarz mimarz deleted the chore/use-biome branch August 1, 2024 12:40
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
mimarz pushed a commit that referenced this pull request Aug 1, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Patch Changes

- chore: Fix rollup build warnings for react package
([#2187](#2187))

- chore: Replace eslint with biomejs
([#2189](#2189))

- fix: Export correct bin files
([`019e72314eff58e9ea575ab5dfb7b7eba6ddaa43`](019e723))

## @digdir/[email protected]

### Patch Changes

- chore: Fix rollup build warnings for react package
([#2187](#2187))

- chore: Replace eslint with biomejs
([#2189](#2189))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mimarz mimarz mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant