chore: upgrade eslint to 9.6.0 #2175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployments for this pull request:
|
mimarz
added a commit
that referenced
this pull request
Aug 1, 2024
**TLDR; Replace eslint and prettier (except css) for linting and formatting.** After doing some testing, debugging and fighting with getting eslint to work in #2175, I made this to test biomejs as a replacement. Either way we had to do big config changes for eslint 9.x so might aswell try biomejs. In general a positive experience having tested biomejs. ## Noticable changes: - Linting is now done for the whole repo, except "ignores". - Seperated gh workflows. - Linting is now done in a separate workflow for the whole repo. - Building and testing the individual packages or apps i their own workflow. (will do more renames here after merging into `next`) - New recommended vscode extension for biomejs. ## Biomejs vs Eslint - Biomejs lints, formats and sorts import order in <1s, while eslint 8.x uses >40s for only linting. - Linting when coding is also noticeably faster - Biomejs is still limited in what can be configured, but most of its current features set is good enough for our needs. - Biomejs is only 1 dependency, opposed to 11 dependencies from eslint - No more hassle upgrading dependencies hopefully - Biomejs lacks: - CSS formatting, ([but its being worked on](https://biomejs.dev/internals/language-support/)), so we are still using prettier for this. - Typed-linting? (i think) - No way of defining our own import order ([RFC](biomejs/biome#3015)) - No plugin support [but its planned](https://biomejs.dev/blog/roadmap-2024/) - Biomejs also has some new good linting rules we fixed - https://biomejs.dev/linter/rules/no-for-each/ - https://biomejs.dev/linter/rules/no-comma-operator/ - https://biomejs.dev/linter/rules/no-shadow-restricted-names/ - https://biomejs.dev/linter/rules/no-useless-else/ - https://biomejs.dev/linter/rules/no-assign-in-expressions/ - https://biomejs.dev/linter/rules/no-accumulating-spread/ - https://biomejs.dev/linter/rules/no-implicit-any-let/
|
deprecated by #2189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1844
This is the start of migrating to eslint version 9.
We have to wait for
eslint-plugin-importto support this, and possibly other plugins.Will leave this PR open for now, so we can easily test a soon as plugins are updated to support the new config format.