Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement item selector info popover (DHIS2-14774) #3274

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Oct 30, 2024

Implements DHIS2-14774

Requires dhis2/analytics#1713


Key features

  1. bump analytics with data item selector info popover feature

Description

In the data item selector, show a popover with information for each data item
The actual implementation is in analytics. Refer to that PR.


TODO

  • Cypress tests
  • Update docs
  • Manual testing
  • task

Known issues

  • issue

Screenshots

Screenshot 2024-11-21 at 12 03 26
Screenshot 2024-11-21 at 12 03 36
Screenshot 2024-11-21 at 12 03 49

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 30, 2024

🚀 Deployed on https://pr-3274.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify October 30, 2024 14:29 Inactive
@edoardo edoardo changed the title chore: update analytics to latest build for testing feat: implement item selector info popover (DHIS2-14774) Nov 4, 2024
@edoardo edoardo force-pushed the feat/info-data-item-selector-DHIS2-14774 branch from 01550b0 to 320b9fa Compare November 8, 2024 14:50
@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 14:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 11:22 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 12, 2024 08:37 Inactive
@edoardo edoardo added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

Data Visualizer App    Run #2957

Run Properties:  status check failed Failed #2957  •  git commit fe396463d4 ℹ️: Merge d9ac7e295e79139fd1a27e0da7560b67c1085221 into 81c9ec3682f0a8843ea84cf754c1...
Project Data Visualizer App
Branch Review feat/info-data-item-selector-DHIS2-14774
Run status status check failed Failed #2957
Run duration 16m 22s
Commit git commit fe396463d4 ℹ️: Merge d9ac7e295e79139fd1a27e0da7560b67c1085221 into 81c9ec3682f0a8843ea84cf754c1...
Committer Edoardo Sabadelli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 37
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 694
View all changes introduced in this branch ↗︎

Tests for review

Failed  open.cy.js • 12 failed tests • e2e-chrome-parallel-2.41-3

View Output Video

Test Artifacts
opening a saved AO > Single value > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Single value > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Single value > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Stacked bar > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Stacked bar > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Stacked bar > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Stacked area > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Stacked area > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Stacked area > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Year over year (column) > opens a saved AO Test Replay Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.
Failed  options/legend.cy.js • 3 failed tests • e2e-chrome-parallel-2.41-3

View Output Video

Test Artifacts
Options - Legend > applies different styles of legend to a Single Value chart Test Replay Screenshots Video
Options - Legend > applies the legend when vis type is changed from Pivot table to Single value Test Replay Screenshots Video
Options - Legend > applies the legend key settings when vis type changes: Column -> Pivot table -> Gauge -> Single value Test Replay Screenshots Video
Failed  new.cy.js • 1 failed test • e2e-chrome-parallel-2.41-2

View Output Video

Test Artifacts
creating a new AO > create AO of type Single value Test Replay Screenshots Video
Failed  options/icon.cy.js • 2 failed tests • e2e-chrome-parallel-2.41-2

View Output Video

Test Artifacts
Icon > no icon shows when option is disabled Test Replay Screenshots Video
Icon > icon shows when option is enabled for INDICATOR Test Replay Screenshots Video
Failed  open.cy.js • 12 failed tests • e2e-chrome-parallel-2.40-3

View Output Video

Test Artifacts
opening a saved AO > Single value > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Single value > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Single value > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Stacked bar > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Stacked bar > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Stacked bar > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Stacked area > opens a saved AO Test Replay Screenshots Video
opening a saved AO > Stacked area > replaces the selected period Test Replay Screenshots Video
opening a saved AO > Stacked area > resets to a new AO Test Replay Screenshots Video
opening a saved AO > Year over year (column) > opens a saved AO Test Replay Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

Flakiness  cypress/integration/confirmLeave.cy.js • 1 flaky test • e2e-chrome-parallel-2.41-1

View Output Video

Test Artifacts
Confirm leave modal > Confirm leave modal preserves AO changes when user cancels leave, and discards changes when user approves leave Test Replay Screenshots Video

@edoardo edoardo removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify November 21, 2024 11:12 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 21, 2024 11:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 22, 2024 14:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 11:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 13:19 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 26, 2024 15:49 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 29, 2024 12:31 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 29, 2024 15:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 4, 2024 10:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants