-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement item selector info popover (DHIS2-14774) #3274
Draft
edoardo
wants to merge
19
commits into
master
Choose a base branch
from
feat/info-data-item-selector-DHIS2-14774
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3274.data-visualizer.netlify.dhis2.org |
edoardo
changed the title
chore: update analytics to latest build for testing
feat: implement item selector info popover (DHIS2-14774)
Nov 4, 2024
edoardo
force-pushed
the
feat/info-data-item-selector-DHIS2-14774
branch
from
November 8, 2024 14:50
01550b0
to
320b9fa
Compare
edoardo
added
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Nov 12, 2024
edoardo
removed
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Nov 12, 2024
This is needed for POST requests to the program indicator expression description endpoint to work correctly.
…-selector-DHIS2-14774
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14774
Requires dhis2/analytics#1713
Key features
Description
In the data item selector, show a popover with information for each data item
The actual implementation is in
analytics
. Refer to that PR.TODO
Known issues
Screenshots