feat: implement info popover for dimensions (DHIS2-14774) #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Implement async request for human readable expressions for some types.
edoardo
force-pushed
the
feat/info-data-item-selector-DHIS2-14774
branch
from
d0edd3f
to
3edb797
Compare
The href is not returned by this api.
This is temporary to avoid the whole modal content to not load.
…-selector-DHIS2-14774
…-selector-DHIS2-14774
This handles the ERROR case, showing the error message from the API.
The list is now aligned with the backend.
This also solves the issue of fetching a DE operand by id in the data info popover.
Reduces code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14774
Relates to dhis2/data-visualizer-app#3274
Key features
Description
This popover shows informations about each data item.
The information shown depends on the item's type.
TODO
Known issues
Screenshots