fix(deps): content of wasm_hash_url can have extra fields than the hash #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwshang
changed the title
ericswanson-dfinity
requested changes
Feb 1, 2024
ericswanson-dfinity
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wasm_hash_urlused to only accept the hash.However, it is natural to point
wasm_hash_urlto the<FILE>.sha256file generated byshasumorsha256sumwhich consists of the hash and the file name.Now when
dfx deps pull, such content will be accept properly.How Has This Been Tested?
e2e deps.bash
Checklist: