Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pullable #98

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: pullable #98

merged 1 commit into from
Feb 8, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Feb 1, 2024

This PR simply adds the required pullable metadata.

To verify the overall workflow, we will need to make a new release so that the wasm module in GitHub release artifacts will have these metadata. And that release should not be "pre-release" in order to be accessible using "latest" label.

And there is an issue on the dfx side which requires wasm_hash_url to contains the hash only. Instead of modifying the CI of this project, I change the dfx deps pull to accept shasum output. PR is pending.

I removed the "pre-release" label of the 0.2.8 release. So that I could verify the wasm_url and wasm_hash_url can be reached.

And I also verified the content of init_guide field is correct to deploy the canister locally.

@THLO
Copy link
Collaborator

THLO commented Feb 7, 2024

The linked PR is no longer pending.
What is still required to drop the Draft label?

@lwshang lwshang marked this pull request as ready for review February 8, 2024 15:38
@lwshang lwshang requested a review from a team as a code owner February 8, 2024 15:38
@lwshang
Copy link
Contributor Author

lwshang commented Feb 8, 2024

This PR is ready.

Notice that the sdk PR was merged but there is no dfx release including it yet. We will likely have one next week.

@lwshang lwshang requested a review from THLO February 8, 2024 15:41
@lwshang lwshang merged commit 1189545 into main Feb 8, 2024
3 checks passed
@lwshang lwshang deleted the lwshang/pullable branch February 8, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants