-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dfx cycles top-up #3419
Merged
Merged
feat: dfx cycles top-up #3419
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8baa248
feat: SDK-1163 dfx cycles transfer (top up)
ericswanson-dfinity 1aca8a6
Update with remediation ticket for cycles-ledger
ericswanson-dfinity 086598a
Disable memo field when sending to a canister
ericswanson-dfinity 18f2d44
command exclusions
ericswanson-dfinity a614eb6
no memo with top up
ericswanson-dfinity e6f086b
separate cycles transfer/top-up commands
ericswanson-dfinity 14b3e55
Merge remote-tracking branch 'origin/master' into ens/sdk-1163-cycles…
ericswanson-dfinity b022e49
format, update docs
ericswanson-dfinity 0e9d413
Merge remote-tracking branch 'origin/master' into ens/sdk-1163-cycles…
ericswanson-dfinity 89d65c9
terminology
ericswanson-dfinity 8ce780f
plural
ericswanson-dfinity cb16ef7
send: log, not println, duplicate message
ericswanson-dfinity 01193b7
Merge branch 'master' into ens/sdk-1163-cycles-transfer-top-up
ericswanson-dfinity 5305341
Remove reference to to-owner mode
ericswanson-dfinity 200dff5
Update docs/cli-reference/dfx-cycles.md
ericswanson-dfinity f1b7e8c
CR suggestion
ericswanson-dfinity 9a28cfc
Merge branch 'master' into ens/sdk-1163-cycles-transfer-top-up
ericswanson-dfinity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there going to be support to specify the amount in a more human-readable format like
100B
or10T
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea for a future improvement. I'll create a ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://dfinity.atlassian.net/browse/SDK-1294