feat: dfx cycles top-up #3419
Merged
feat: dfx cycles top-up #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested review from
chenyan-dfinity and
a team
as code owners
ericswanson-dfinity
changed the title
sesi200
reviewed
Oct 16, 2023
Describe more about difference between sending to an account and sending to a canister.
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
…t stdout (#3420) If the replica reports a duplicate transaction in `dfx ledger transfer`, dfx prints out a message about this. This change logs that message at info level, rather than printing it to stdout. This makes the stdout output of `dfx ledger transfer` consistent. Why info level, rather than warn level? Anyone calling `dfx ledger transfer`, even without specifying `--created-at-time`, can see this duplicate transaction message. This is because dfx retries failures, and uses a consistent created_at_time (either from `--created-at-time`, or by getting the current system time before the first attempt). It's possible that a call succeeds, but there is an i/o error before dfx receives the response. In this case dfx will retry, and get a duplicate transaction result. Motivation: #3419 (comment)
ericswanson-dfinity
changed the title
ghost
approved these changes
Oct 17, 2023
THLO
reviewed
Oct 18, 2023
THLO
reviewed
Oct 18, 2023
| | `--created-at-time <timestamp>` | Specify the timestamp-nanoseconds for the `created_at_time` field on the transfer request. Useful for controlling transaction-de-duplication. https://internetcomputer.org/docs/current/developer-docs/integrations/icrc-1/#transaction-deduplication- | | ||
|
|
||
| ### Examples | ||
|
|
||
| Transfer 1 billion cycles to another account: | ||
|
|
||
| ``` bash | ||
| dfx cycles transfer 1000000000 --to-owner raxcz-bidhr-evrzj-qyivt-nht5a-eltcc-24qfc-o6cvi-hfw7j-dcecz-kae --network ic | ||
| dfx cycles transfer raxcz-bidhr-evrzj-qyivt-nht5a-eltcc-24qfc-o6cvi-hfw7j-dcecz-kae 1000000000 --network ic |
There was a problem hiding this comment.
Is there going to be support to specify the amount in a more human-readable format like 100B or 10T?
There was a problem hiding this comment.
That's a great idea for a future improvement. I'll create a ticket.
There was a problem hiding this comment.
THLO
reviewed
Oct 18, 2023
THLO
reviewed
Oct 18, 2023
THLO
approved these changes
Oct 18, 2023
Co-authored-by: Thomas Locher <[email protected]>
Co-authored-by: Thomas Locher <[email protected]>
Co-authored-by: Thomas Locher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
dfx cycles top-up <to canister name or principal> <amount>for transferring cycles from your account to a canister.Also changed the
--to-ownerparameter ofdfx cycles transferto be positional, and updated the tests and docs for it, sincedfx cycles transferanddfx cycles top-upwill now be separate commands.Fixes https://dfinity.atlassian.net/browse/SDK-1163
How Has This Been Tested?
Updated and added e2e tests.
Checklist: