Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove project specific network deprecation warning #3374

Merged
merged 3 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ If `dfx start` is starting the shared network from within a dfx project, and tha

The parameter was erroneously passed twice. Now it is passed only once.

### fix: Removed deprecation warning about project-specific networks

Removed this warning: "Project-specific networks are deprecated and will be removed after February 2023." While we may remove project-specific networks in the future, it is not imminent. One key requirement is the ability to run more than one subnet type at one time.

## Dependencies

### Frontend canister
Expand Down
2 changes: 0 additions & 2 deletions docs/cli-reference/dfx-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,4 @@ dfx stores data for the shared local network in one of the following locations,

If dfx.json defines the `local` network, then `dfx start` will use this definition and store network data files under `\<project dir\>/.dfx/network/local`.

Such project-specific networks are deprecated, and we plan to remove support for them after February 2023. We encourage you to remove any definitions of the `local` network from your project's dfx.json file and instead use the default shared local network.

Note that for projects that define the `local` network in dfx.json, you can only run the `dfx start` and `dfx stop` commands from within the project directory structure. For example, if your project name is `hello_world`, your current working directory must be the `hello_world` top-level project directory or one of its subdirectories.
4 changes: 0 additions & 4 deletions src/dfx-core/src/network/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,6 @@ fn create_project_network_descriptor(
network_name,
config.get_path().display(),
);
warn!(
logger,
"Project-specific networks are deprecated and will be removed after February 2023."
);

let data_directory = config.get_temp_path().join("network").join(network_name);
let legacy_pid_path = Some(config.get_temp_path().join("pid"));
Expand Down
Loading